MNT: More testing cleanups for coverage.

Remove unused code and restructure to eliminate uncovered lines.

Author: dopplershift

lib/matplotlib/tests/test_collections.py

@@ -383,16 +383,6 @@ def check_segments(coll, positions, linelength, lineoffset, orientation):
         assert_equal(segment[1, pos2], positions[i])
 
 
-def check_allprop(values, target):
-    '''
-    check to make sure all values match the given target
-
-    note: this is not a test, it is used by tests
-    '''
-    for value in values:
-        assert_equal(value, target)
-
-
 def check_allprop_array(values, target):
     '''
     check to make sure all values match the given target if arrays

lib/matplotlib/tests/test_triangulation.py

@@ -966,8 +966,8 @@ def test_triplot_return():
     triang = mtri.Triangulation(
         [0.0, 1.0, 0.0, 1.0], [0.0, 0.0, 1.0, 1.0],
         triangles=[[0, 1, 3], [3, 2, 0]])
-    if ax.triplot(triang, "b-") is None:
-        raise AssertionError("triplot should return the artist it adds")
+    assert ax.triplot(triang, "b-") is not None, \
+        'triplot should return the artist it adds'
 
 
 def test_trirefiner_fortran_contiguous_triangles():

lib/matplotlib/tests/test_widgets.py

@@ -261,9 +261,7 @@ def test_CheckButtons():
     check.set_active(0)
     assert check.get_status() == [False, False, True]
 
-    def clicked_function():
-        pass
-    cid = check.on_clicked(clicked_function)
+    cid = check.on_clicked(lambda: None)
     check.disconnect(cid)