fix: rotationCorrection bug fixes #194
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
can you provide a sample video to test? this breaks rotation == 90 which is handled here |
|
this only fixes the aspect ratio, but the video is still flipped/ rotation is not correct, you can use video captured in iOS and use it in linux |
|
video renderer will rotate the content, so changing the size is enough in player.dart. i don't have an ios device. |
|
tested on linux and it doesnt' |
|
I don't have linux environment. It works correctly on macOS. the rotation code is the same on all platforms. can you show me the log |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.