Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

EIP 712: use per-contract verifying addresses #116

Open
oberstet opened this issue Apr 28, 2020 · 1 comment
Open

EIP 712: use per-contract verifying addresses #116

oberstet opened this issue Apr 28, 2020 · 1 comment
Labels

Comments

@oberstet
Copy link
Member

oberstet commented Apr 28, 2020

For all of the XBR contracts, the respective xyzFor() functions should use the respective contract instance address - not generally the address of the XBRNetwork contract.

Eg here https://github.com/crossbario/xbr-protocol/blob/0c29d5ec751cbde5db00ca37b703297adb0f8c16/contracts/XBRChannel.sol#L138

^ should use address(this) rather than market.network().verifyingContract()

@oberstet oberstet added the bug label Apr 28, 2020
@oberstet
Copy link
Member Author

it's also important to stress: once we go to #9, above verifying address should be the addresses of the implementation contracts, rather than the proxy contracts.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant