Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Incorrect consistency adjustment item type #35

Open
ausov opened this issue Nov 26, 2023 · 1 comment · May be fixed by #36
Open

Incorrect consistency adjustment item type #35

ausov opened this issue Nov 26, 2023 · 1 comment · May be fixed by #36

Comments

@ausov
Copy link

ausov commented Nov 26, 2023 •
edited
Loading

Consistency adjustment item type is not always correctly selected. Disabled consistency check can submit wrong data to API.

There seems to be an error in \WC_Wallee_Helper::cleanup_line_items. It's using $enforce_consistency variable for number comparison which is a boolean option. Should be using$inconsistent_amount variable instead.
ausov added a commit to ausov/wallee-woocommerce that referenced this issue Nov 26, 2023
@ausov
Fix consistency adjustment item type
a2ce1eb 
Closes wallee-payment#35
@ausov ausov linked a pull request Nov 26, 2023 that will close this issue
Open
@ausov ausov changed the title Disabled consistency check can submit wrong data to API Incorrect consistency adjustment item type Nov 26, 2023
@thibault-mambour
Copy link

hi @ausov , sorry for the late reply but the developers told me that this should have been fixed with the latest release. Could you please double check ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix consistency adjustment item type ausov/wallee-woocommerce
2 participants
@ausov @thibault-mambour