Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: Negentropy error handling improvements #3030

Open
SionoiS opened this issue Sep 10, 2024 · 0 comments
Open

chore: Negentropy error handling improvements #3030

SionoiS opened this issue Sep 10, 2024 · 0 comments
Labels
effort/days Estimated to be completed in a few days, less than a week enhancement New feature or request

Comments

@SionoiS
Copy link
Contributor

SionoiS commented Sep 10, 2024

Background

The Negentropy bindings used by Waku Sync do not return specific errors only a bool. During dogfooding we notice some errors but can't tell if they are expected or not because they can't be differentiated.

Details

Improve the binding code (Nim, C, C++) so that we can get error details.

Acceptance criteria

Nim code can distinguish different Negentropy errors.
@SionoiS SionoiS added the enhancement New feature or request label Sep 10, 2024
@Ivansete-status Ivansete-status added the effort/days Estimated to be completed in a few days, less than a week label Sep 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
effort/days Estimated to be completed in a few days, less than a week enhancement New feature or request
Projects
Waku
Status: Priority
Milestone
No milestone
Development

No branches or pull requests
2 participants
@SionoiS @Ivansete-status