Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: numPeers in BaseProtocol.getPeers() should not take 0 for all peers #2055

Open
danisharora099 opened this issue Jul 8, 2024 · 0 comments
Labels
debt Technical debt marker enhancement New feature or request

Comments

@danisharora099
Copy link
Collaborator

This is a change request

Problem

* @param numPeers - The total number of peers to retrieve. If 0, all peers are returned.
numPeers takes in 0 as the value if all peers are to be returned. This is unintuitive to correlate 0 with all peers

Proposed Solutions

Using Infinity instead of 0 would be more intuitive

Notes

@weboko weboko added enhancement New feature or request debt Technical debt marker labels Jul 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
debt Technical debt marker enhancement New feature or request
Projects
Status: To Do
Development

No branches or pull requests

2 participants