You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Right. Taking an example of LightPush for an analogy, that we can extend to other protocols:
LightPushCore extends BaseProtocol (has existed)
This is essential for mostly two things currently:
Stream Management -- getting a stream from a connection to the peer
getPeers() -- getting connected peers, for the relevant pubsub topic & protocol
Introduction of BaseProtocolSDK -- let's call it PeerManager for now
This module was introduced simply for peer management for each protocol.
This is responsible for maintain a pool of peers, and functionalities like renewing peers. This is similar to the functionality expected from BaseProtocol. Perhaps a merge of these two files, into PeerManager looks like the way ahead.
We can rename BaseProtocolSDK to be PeerManager, which at this point, seems more appropriate and reliable.
Conclusion
I'd go so far to say we can remove BaseProtocolCore in favour of moving functionalities into PeerManager.
Action points I'd derive for this issue:
rename BaseProtocolSDK to PeerManager
remove BaseProtocolCore, and move logic into PeerManager
This is a change request
Problem
As of now we have convoluted class structure when:
FilterSDK.super -> BaseSDK.core -> FilterCore.super -> BaseProtocol
Proposed Solutions
Let's revisit it and try to remove extra steps in that chain.
Notes
Original threads: #2003 (comment) and #2003 (comment)
The text was updated successfully, but these errors were encountered: