Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug: intermittent data race noticed in CI #984

Open
chaitanyaprem opened this issue Jan 2, 2024 · 0 comments
Open

bug: intermittent data race noticed in CI #984

chaitanyaprem opened this issue Jan 2, 2024 · 0 comments
Labels
bug Something isn't working

Comments

@chaitanyaprem
Copy link
Collaborator

Describe the bug
Noticed the below data race only once in the CI, on rerunning the tests they succeeded.


==================
WARNING: DATA RACE
Write at 0x00c0002c9a00 by goroutine 1316:
  github.com/waku-org/go-waku/waku/v2/protocol/relay.(*WakuRelay).SetHost()
      /home/runner/work/go-waku/go-waku/waku/v2/protocol/relay/waku_relay.go:122 +0x3d
  github.com/waku-org/go-waku/waku/v2/node.(*WakuNode).Start()
      /home/runner/work/go-waku/go-waku/waku/v2/node/wakunode2.go:427 +0x14a7
  github.com/waku-org/go-waku/waku/v2/node.TestUpAndDown()
      /home/runner/work/go-waku/go-waku/waku/v2/node/wakunode2_test.go:105 +0x704
  testing.tRunner()
      /opt/hostedtoolcache/go/1.20.12/x64/src/testing/testing.go:1576 +0x216
  testing.(*T).Run.func1()
      /opt/hostedtoolcache/go/1.20.12/x64/src/testing/testing.go:1629 +0x47

Previous read at 0x00c0002c9a00 by goroutine 1935:
  github.com/waku-org/go-waku/waku/v2/protocol/relay.(*WakuRelay).peerScoreInspector()
      /home/runner/work/go-waku/go-waku/waku/v2/protocol/relay/waku_relay.go:105 +0x54
  github.com/waku-org/go-waku/waku/v2/protocol/relay.(*WakuRelay).peerScoreInspector-fm()
      <autogenerated>:1 +0x44
  github.com/libp2p/go-libp2p-pubsub.(*peerScore).inspectScoresExtended.func1()
      /home/runner/go/pkg/mod/github.com/libp2p/[email protected]/score.go:499 +0x47

Goroutine 1316 (running) created at:
  testing.(*T).Run()
      /opt/hostedtoolcache/go/1.20.12/x64/src/testing/testing.go:1629 +0x805
  testing.runTests.func1()
      /opt/hostedtoolcache/go/1.20.12/x64/src/testing/testing.go:2036 +0x8d
  testing.tRunner()
      /opt/hostedtoolcache/go/1.20.12/x64/src/testing/testing.go:1576 +0x216
  testing.runTests()
      /opt/hostedtoolcache/go/1.20.12/x64/src/testing/testing.go:2034 +0x87c
  testing.(*M).Run()
      /opt/hostedtoolcache/go/1.20.12/x64/src/testing/testing.go:1906 +0xb44
  main.main()
      _testmain.go:63 +0x2e9

Goroutine 1935 (finished) created at:
  github.com/libp2p/go-libp2p-pubsub.(*peerScore).inspectScoresExtended()
      /home/runner/go/pkg/mod/github.com/libp2p/[email protected]/score.go:499 +0x564
  github.com/libp2p/go-libp2p-pubsub.(*peerScore).inspectScores()
      /home/runner/go/pkg/mod/github.com/libp2p/[email protected]/score.go:453 +0x6a
  github.com/libp2p/go-libp2p-pubsub.(*peerScore).background.func5()
      /home/runner/go/pkg/mod/github.com/libp2p/[email protected]/score.go:423 +0x39
  runtime.deferreturn()
      /opt/hostedtoolcache/go/1.20.12/x64/src/runtime/panic.go:476 +0x32
  github.com/libp2p/go-libp2p-pubsub.(*peerScore).Start.func1()
      /home/runner/go/pkg/mod/github.com/libp2p/[email protected]/score.go:251 +0x58
==================
@chaitanyaprem chaitanyaprem added the bug Something isn't working label Jan 3, 2024
@chaitanyaprem chaitanyaprem self-assigned this Jan 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Status: No status
Development

No branches or pull requests

1 participant