Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Newsletter images should preserve their aspect ratio on mobile #372

Open
thibaudcolas opened this issue Mar 30, 2023 · 3 comments
Open

Newsletter images should preserve their aspect ratio on mobile #372

thibaudcolas opened this issue Mar 30, 2023 · 3 comments
Labels
bug Something isn't working

Comments

@thibaudcolas
Copy link
Member

Reported by Ester in Twitter DMs, see for example TWIW #122. Example:

screenshot of TWIW on mobile, with one screenshot looking off

@thibaudcolas thibaudcolas added the bug Something isn't working label Mar 30, 2023
@MAYANKpandey14
Copy link

Hey @thibaudcolas

@MAYANKpandey14
Copy link

Cause of Bug

I think the cause of this bug is the explicit mentioning of height and width of the img tag. If we remove that the image works fine and maintains the aspect ratio.

image

Also the use of CSS styles and properties are not done in an effective manner.

image

Solution

Simple solution would be to remove the explicit mentioning of height and width in the IMG tag and customize the CSS properties so that IMG works properly across all devices .

Also, I would like to work on this issue.

@nicklee
Copy link
Member

nicklee commented Aug 3, 2023

this can be fixed by adding height: auto; to .richtext-image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants