-
Notifications
You must be signed in to change notification settings - Fork 34
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/detailed segment visits #174
base: master
Are you sure you want to change the base?
Conversation
Codecov Report
@@ Coverage Diff @@
## master #174 +/- ##
==========================================
+ Coverage 67.51% 67.78% +0.27%
==========================================
Files 55 56 +1
Lines 2358 2409 +51
==========================================
+ Hits 1592 1633 +41
- Misses 766 776 +10
Continue to review full report at Codecov.
|
return visit | ||
|
||
@classmethod | ||
def reverse_match(cls, user): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The session_key
used in the SegmentVisit
class changes every time a user logs in and logs out. Is there an other way to recognise previous visits of a user without using this session key?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Might be the secret key not being set properly.
1c284e4
to
3ef7861
Compare
Codecov Report
@@ Coverage Diff @@
## master #174 +/- ##
===========================================
- Coverage 89.76% 67.78% -21.98%
===========================================
Files 52 56 +4
Lines 1153 2409 +1256
===========================================
+ Hits 1035 1633 +598
- Misses 118 776 +658
Continue to review full report at Codecov.
|
No description provided.