Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/detailed segment visits #174

Open
wants to merge 6 commits into
base: master
Choose a base branch
from

Conversation

jberghoef
Copy link
Contributor

No description provided.

@codecov
Copy link

codecov bot commented Aug 25, 2017

Codecov Report

Merging #174 into master will increase coverage by 0.27%.
The diff coverage is 81.17%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #174      +/-   ##
==========================================
+ Coverage   67.51%   67.78%   +0.27%     
==========================================
  Files          55       56       +1     
  Lines        2358     2409      +51     
==========================================
+ Hits         1592     1633      +41     
- Misses        766      776      +10
Impacted Files Coverage Δ
src/wagtail_personalisation/receivers.py 100% <ø> (ø) ⬆️
tests/unit/test_adapter_session.py 100% <ø> (ø) ⬆️
src/wagtail_personalisation/rules.py 100% <ø> (ø) ⬆️
...isation/migrations/0013_detailed-segment-visits.py 100% <100%> (ø)
src/wagtail_personalisation/wagtail_hooks.py 49.45% <50%> (ø) ⬆️
src/wagtail_personalisation/adapters.py 23.83% <66.66%> (-0.23%) ⬇️
src/wagtail_personalisation/models.py 84.44% <76.92%> (-0.27%) ⬇️
src/wagtail_personalisation/views.py 57.5% <94.44%> (+7.5%) ⬆️
... and 3 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0d9e4aa...1c284e4. Read the comment docs.

return visit

@classmethod
def reverse_match(cls, user):
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The session_key used in the SegmentVisit class changes every time a user logs in and logs out. Is there an other way to recognise previous visits of a user without using this session key?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Might be the secret key not being set properly.

@jberghoef jberghoef force-pushed the feature/detailed-segment-visits branch from 1c284e4 to 3ef7861 Compare May 26, 2018 13:56
@codecov-io
Copy link

Codecov Report

Merging #174 into master will decrease coverage by 21.97%.
The diff coverage is 81.17%.

Impacted file tree graph

@@             Coverage Diff             @@
##           master     #174       +/-   ##
===========================================
- Coverage   89.76%   67.78%   -21.98%     
===========================================
  Files          52       56        +4     
  Lines        1153     2409     +1256     
===========================================
+ Hits         1035     1633      +598     
- Misses        118      776      +658
Impacted Files Coverage Δ
src/wagtail_personalisation/rules.py 100% <ø> (+23.74%) ⬆️
src/wagtail_personalisation/receivers.py 100% <ø> (ø) ⬆️
tests/unit/test_adapter_session.py 100% <ø> (ø) ⬆️
...isation/migrations/0013_detailed-segment-visits.py 100% <100%> (ø)
src/wagtail_personalisation/wagtail_hooks.py 49.45% <50%> (-23.81%) ⬇️
src/wagtail_personalisation/adapters.py 23.83% <66.66%> (-74%) ⬇️
src/wagtail_personalisation/models.py 84.44% <76.92%> (-0.27%) ⬇️
src/wagtail_personalisation/views.py 57.5% <94.44%> (+7.5%) ⬆️
src/wagtail_personalisation/admin_urls.py 26.31% <0%> (-73.69%) ⬇️
... and 11 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 83c2a42...3ef7861. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants