Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Missing media in SegmentModelAdmin #194

Open
aweakley opened this issue Oct 29, 2018 · 2 comments
Open

Missing media in SegmentModelAdmin #194

aweakley opened this issue Oct 29, 2018 · 2 comments

Comments

@aweakley
Copy link
Contributor

In our segment admin view at /admin/wagtail_personalisation/segment/edit/1/ the page chooser in the Visit Count Rule does not pop up the modal because wagtailadmin/js/page-chooser.js and wagtailadmin/js/page-chooser-modal.js are missing from the media.
I've fixed it by adding those files to SegmentModelAdmin.form_view_extra_js, but is there a better way?
jberghoef added a commit that referenced this issue Oct 30, 2018
@jberghoef
Prevent overriding media files as to load the page chooser
d9ef74c 
Fixes #194
@jberghoef jberghoef mentioned this issue Oct 30, 2018
Open
@jberghoef
Copy link
Contributor

The issue seems to have been caused by overriding the extra_js template block. #195 should fix this.

@aweakley
Copy link
Contributor Author

That didn't fix it for me I'm afraid. I've pulled d9ef74c and I'm getting the same behaviour.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@aweakley @jberghoef