Skip to content

Commit 00e991b

Browse files
authored
Update patch for ed/idl/payment-handler.idl (#1314)
Drop all interfaces, now re-introduced in Payment Request, but keep the `AddressInit` dictionary, which is still missing.
1 parent 03a9dfc commit 00e991b

File tree

1 file changed

+12
-50
lines changed

1 file changed

+12
-50
lines changed
Lines changed: 12 additions & 50 deletions
Original file line numberDiff line numberDiff line change
@@ -1,24 +1,21 @@
1-
From a651ec2cd18532034bfdd512aafa8cfb2d160e6a Mon Sep 17 00:00:00 2001
1+
From e6179dbe95efd530dbeca7ccc474aafc249a340b Mon Sep 17 00:00:00 2001
22
From: Francois Daoust <[email protected]>
3-
Date: Fri, 13 Jan 2023 15:07:47 +0100
4-
Subject: [PATCH] Add missing Payment Request IDL dfns
3+
Date: Mon, 19 Aug 2024 10:45:38 +0200
4+
Subject: [PATCH] Add missing AddressInit dictionary
55

6-
Payment Handler re-introduced billing address support, expecting Payment Request
7-
to do the same, but Payment Request has not yet been updated. This patch adds
8-
missing dictionary definitions to Payment Handler.
9-
10-
Tests will fail once Payment Request gets updated, signaling it is time to drop
11-
the patch:
12-
https://github.com/w3c/payment-request/pull/996
6+
Payment Request re-introduced most of the missing interfaces, except the
7+
`AddressInit` dictionary. This patch adds it pending proper resolution of the
8+
underlying problem, see:
9+
https://github.com/w3c/payment-handler/issues/412
1310
---
14-
ed/idl/payment-handler.idl | 48 ++++++++++++++++++++++++++++++++++++++
15-
1 file changed, 48 insertions(+)
11+
ed/idl/payment-handler.idl | 13 +++++++++++++
12+
1 file changed, 13 insertions(+)
1613

1714
diff --git a/ed/idl/payment-handler.idl b/ed/idl/payment-handler.idl
18-
index e039dd809..d0e5bd9fd 100644
15+
index 1f6eaae2b..8aa55e9e9 100644
1916
--- a/ed/idl/payment-handler.idl
2017
+++ b/ed/idl/payment-handler.idl
21-
@@ -104,3 +104,51 @@ DOMString? payerPhone;
18+
@@ -81,3 +81,16 @@ DOMString? payerPhone;
2219
AddressInit shippingAddress;
2320
DOMString? shippingOption;
2421
};
@@ -35,41 +32,6 @@ index e039dd809..d0e5bd9fd 100644
3532
+ DOMString recipient = "";
3633
+ DOMString phone = "";
3734
+};
38-
+
39-
+dictionary PaymentOptions {
40-
+ boolean requestPayerName = false;
41-
+ boolean requestBillingAddress = false;
42-
+ boolean requestPayerEmail = false;
43-
+ boolean requestPayerPhone = false;
44-
+ boolean requestShipping = false;
45-
+ PaymentShippingType shippingType = "shipping";
46-
+};
47-
+
48-
+dictionary PaymentShippingOption {
49-
+ required DOMString id;
50-
+ required DOMString label;
51-
+ required PaymentCurrencyAmount amount;
52-
+ boolean selected = false;
53-
+};
54-
+
55-
+enum PaymentShippingType {
56-
+ "shipping",
57-
+ "delivery",
58-
+ "pickup"
59-
+};
60-
+
61-
+dictionary AddressErrors {
62-
+ DOMString addressLine;
63-
+ DOMString city;
64-
+ DOMString country;
65-
+ DOMString dependentLocality;
66-
+ DOMString organization;
67-
+ DOMString phone;
68-
+ DOMString postalCode;
69-
+ DOMString recipient;
70-
+ DOMString region;
71-
+ DOMString sortingCode;
72-
+};
7335
--
74-
2.39.0.windows.2
36+
2.37.1.windows.1
7537

0 commit comments

Comments
 (0)