Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

getPropertyType and SVGScriptElement href baseVal property #521

Open
lukewarlow opened this issue Jun 12, 2024 · 3 comments
Open

getPropertyType and SVGScriptElement href baseVal property #521

lukewarlow opened this issue Jun 12, 2024 · 3 comments
Labels

Comments

@lukewarlow
Copy link
Member

Currently getPropertyType's spec and both Chromium and WebKit's implementation has no handling of the .href.baseVal property of an SVGScriptElement, but it does require a TrustedScriptURL.

cc @koto what should we do here?

@koto
Copy link
Member

koto commented Jun 28, 2024

Realistically we only have two choices, either ignore it (as baseVal is a property of SVGAnimatedString and not an element), or use a meta syntax like href.baseVal for the property name and add an entry for it in getPropertyType.

I have a slight preference to the former - getPropertyType does not cover all TT sinks, and we should just assume that SVG animations are another vector that needs to be handled separately.

@lukewarlow
Copy link
Member Author

Yeah I have a preference for ignoring it too. Same way lots of functions require a trusted type without a metadata API.

@fred-wang
Copy link
Contributor

cc @smaug----

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants