Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check variable naming inside of getAttributeType and getPropertyType methods #496

Open
lukewarlow opened this issue Mar 28, 2024 · 2 comments
Labels

Comments

@lukewarlow
Copy link
Member

See WebKit/WebKit#26552 (comment) for context but TLDR make sure these two functions have parameters and variables named coherently.

@koto koto added the spec label May 6, 2024
@fred-wang
Copy link
Contributor

So IIUC, the problem is the confusion with Element.tagName) which returns uppercased qualified name. So the suggestion is to rename the tagName parameter to use localName instead?

@fred-wang
Copy link
Contributor

cc @smaug----

So another source of confusion is the "attribute" argument from getAttributeType().

Comparing with [createAttribute(https://dom.spec.whatwg.org/#dom-document-createattribute)] and createAttributeNS, it could better be renamed "local name" or "qualified name".

Besides lowercasing (see #424 for a proposal to remove that), the argument is pass as is to Get Trusted Type data for attribute which treats it as a "local name", so it seems what this attribute really is.

moz-wptsync-bot pushed a commit to web-platform-tests/wpt that referenced this issue Oct 23, 2024
moz-v2v-gh pushed a commit to mozilla/gecko-dev that referenced this issue Oct 23, 2024
moz-wptsync-bot pushed a commit to web-platform-tests/wpt that referenced this issue Oct 23, 2024
moz-wptsync-bot pushed a commit to web-platform-tests/wpt that referenced this issue Oct 23, 2024
ErichDonGubler pushed a commit to erichdongubler-mozilla/firefox that referenced this issue Oct 23, 2024
i3roly pushed a commit to i3roly/firefox-dynasty that referenced this issue Oct 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants