Skip to content

Remove DisplayMediaStreamConstraints use #23

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
youennf opened this issue Aug 25, 2022 · 3 comments
Closed

Remove DisplayMediaStreamConstraints use #23

youennf opened this issue Aug 25, 2022 · 3 comments

Comments

@youennf
Copy link

youennf commented Aug 25, 2022

DisplayMediaStreamConstraints has been removed from screen share spec.
We should have a ViewPortCaptureMediaStreamOptions instead of reusing/extending DisplayMediaStreamConstraints.
@youennf youennf mentioned this issue Aug 25, 2022
Merged
@dontcallmedom
Copy link
Member

dup of #21 (for which #22 is pending)

@alvestrand
Copy link

The screen share renamed it, it did not remove it. We should switch to using the new name, not start inventing new stuff.

@dontcallmedom
Copy link
Member

I don't think the options in DisplayMediaStreamOptions such as surfaceSwitching or selfBrowserSurface makes sense in the context of getViewportMedia, so using a dedicated dictionary as suggested in #22 seems preferable.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@dontcallmedom @alvestrand @youennf