Skip to content
This repository has been archived by the owner on Feb 1, 2022. It is now read-only.

Need measureType for accurate reprojection #80

Open
robman opened this issue Jun 11, 2015 · 5 comments
Open

Need measureType for accurate reprojection #80

robman opened this issue Jun 11, 2015 · 5 comments

Comments

@robman
Copy link
Contributor

robman commented Jun 11, 2015

The discussion in #77 did highlight that this IS necessary - yet it got dropped 8(
See:
#77 (comment)
#77 (comment)

@anssiko
Copy link
Member

anssiko commented Jun 12, 2015

We should bring measureType back if:

  • there is a good use case for it
  • multiple independent implementations are able to provide such information

@anssiko
Copy link
Member

anssiko commented Nov 10, 2015

I'll close this. We can revisit this when we are aware of multiple independent implementations that are able to support measureType.

@robman
Copy link
Contributor Author

robman commented Oct 21, 2016

This is critical for accurate reprojection and should really be included in v1.

Based on discussion with @huningxin this should probably be able to be requested in the constraints too (and be introspected/throw errors) as some devices let you configure if you want to use optical or principal ray.

@anssiko anssiko changed the title Bring back measureType Need measureType for accurate reprojection Oct 31, 2016
@robman robman removed the v2 label Nov 15, 2016
@astojilj
Copy link
Contributor

Copying the quote from the comment here to define measure type:
#77 (comment)

the measureType defines if the length is measured along the optical axis (depth down the X3 axis in the pinhole camera model) or as a ray (along the effective hypotenuse). Again this tells us what algorithm to use.

robman@, I understand that the use case for this is inverse linear relationship in disparity mode of RealSense R200 camera:
float depth_in_meters = scale / image[pixel_index];

For the reference, in z16 mode it behaves similar to Kinect2, with near = 0, far = 65535mm (scale == 1mm) and
float depth_in_meters = scale * image[pixel_index];.

Are there other cases you know of? Thanks.

@huningxin
Copy link
Contributor

huningxin commented Nov 16, 2016

@robman I agree this is critical for accurate reprojection.

However, to my knowledge, the depth value is commonly OpticalAxis measurement type, like RealSense and Kinect. Do you know any camera or SDK provide the OpticalRay depth value?

If OpticalAxis is the default one, can we specify the measurement of depth value in this spec is OpticalAxis instead of adding measurementType constraint? WDYT?

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants