-
Notifications
You must be signed in to change notification settings - Fork 20
Improve examples #57
Comments
@astojilj promised to improve the examples inline with the API changes that will land soon. |
Could reuse some examples for the @astojilj's article: https://01.org/chromium/blogs/astojilj/2017/depth-camera-capture-html5 I suggest checking any example code we add to the spec with http://jshint.com/. |
The second example is impossible to follow as it only does half of what it says and just contains a lot of ... :-) https://github.com/01org/depth-camera-web-demo/blob/master/depthdemo.html does more or less what it says, but contains optimizations using extensions etc. If that could be simplified somehow we might be able to include it some how... Shaders could be multiline using ``
|
@kenchris Usage of floats mandates activating via extension (otherwise no way to use float and it is the only and seems like the best way): In WebGL2, EXT_color_buffer_float also brings a possibility to use single component float, with 4x lower bandwidth and much faster upload to texture consumption. I don't know about the platform where these extensions are not supported. Good point about multiline, will upload the demo. Thanks. |
@astojilj I guess we could change the example then to more or less what you are doing in your demo. I think for the sake of the spec, showing webgl2 should be fine. It is an example after all and it will be widely supported (Safari said they will support it too in addition to their WebGPU work) |
According to Marcos it is fine to use ES15 in specs, like 'let' in loops and => instead of functions.
Also s/reason/err/ in the promise catch. And write out gUM. it is not obvious what that is, and examples should be obvious
The text was updated successfully, but these errors were encountered: