Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

No way to localize icons? #1077

Closed
aphillips opened this issue May 15, 2023 · 3 comments · Fixed by #1101
Closed

No way to localize icons? #1077

aphillips opened this issue May 15, 2023 · 3 comments · Fixed by #1101
Labels
i18n-needs-resolution Issue the Internationalization Group has raised and looks for a response on.

Comments

@aphillips
Copy link
Contributor

Declaring multiple icons
https://w3c.github.io/manifest/#declaring-multiple-icons

In the following example, the developer has made the following choices about the icons associated with the web application (etc.)

There are ways to include multiple icons with different sizes, but there is no way to indicate when these should be used with specific locales, such as when the icon contains localizable text or when there are regional variations in the icon.

@aphillips aphillips added the i18n-needs-resolution Issue the Internationalization Group has raised and looks for a response on. label May 15, 2023
@valioDOTch
Copy link
Contributor

Wouldn't it make more sense to serve a localized manifest based on the clients preferred language, that would also provide the corresponding "lang" attribute in the manifest?

@aphillips
Copy link
Contributor Author

Serving a correctly localized manifest certainly makes sense, but this can be a little complicated. If the manifest files are not generated dynamically but instead use path or file-naming to separate them, an application might choose to bundle a number of related locales together with locally variant icons. For example:

"lang": "fr",
"dir": "ltr",
"name": "une application",
"icons":  [
    {
        "lang": "fr-FR",
        "comment": "a bit of bleu-blanc-rouge",
        "src": "icon-for-france.jpg"
    },
    {
        "lang": "fr-CH",
        "comment": "red with a little white +",
        "src": "icon-for-suisse.jpg"
    },
    {
        "comment": "no special flag-related motif",
        "src": "default-french-icon.jpg"
    }
]

@christianliebel
Copy link
Member

#1101 would introduce a way to localize icons:

{
  "lang": "en-US",
  "icons": [
    { "src": "icon/lowres.png", "sizes": "64x64" },
    { "src": "icon/hires.png", "sizes": "256x256" }
  ],
  "icons_localized": {
    "fr": [
      { "src": "icon/lowres_fr.png", "sizes": "64x64" },
      { "src": "icon/hires_fr.png", "sizes": "256x256" }
    ]
  }
}

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
i18n-needs-resolution Issue the Internationalization Group has raised and looks for a response on.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants