-
Notifications
You must be signed in to change notification settings - Fork 35
compaction: t0112, t0113 in LD 1.0 processing mode #649
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
gkellogg
added a commit
that referenced
this issue
Apr 22, 2025
…Version: 1.1` to not interfer with 1.0 development. Fixes #649.
You're correct that these should both be set to This was probably not caught, as we don't expect developers to work towards a distinct "1.0" vs. "1.1" mode, but rather wanted to give a way for developer who were using the 1.0 test suite to filter out 1.1-specific tests (and for 1.1 developers to ignore specific 1.0 tests). Fixed in #655. |
Brilliant, thanks! |
gkellogg
added a commit
that referenced
this issue
Jun 4, 2025
…Version: 1.1` to not interfer with 1.0 development. Fixes #649.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Uh oh!
There was an error while loading. Please reload this page.
I'm running into an issue with t0112 and t0113 in compaction. No specVersion or processingMode is specified for those tests, so I'm assuming they should pass in ld-1.0 and ld-1.1.
However, I can't get them to pass on 1.0.
For t0112, the context is:
For t0113, the context is:
When running in LD 1.0 mode, I get an "Invalid Term Definition", based on step 20.1 in Create Term:
The way I'm reading that is that if a property definition has an
@index
entry, and we're in LD 1.0 mode we need to bail out. The definition ofprop
includes@index
, so it can't pass?Looking at the expansion tests, I don't think there's one where
@index
is set on a term in an@context
that runs for LD 1.0.The text was updated successfully, but these errors were encountered: