Contacts are not properly sorted by address

[w-yeehong]

Expected Outcome

After sorting the list of contacts by address, contacts should be properly sorted, with the entries without addresses at the bottom of the list.

Description

Contacts are not properly sorted by address. There are some entries without addresses in the middle of the list.

Steps to Reproduce

1. Execute sort -c 2.

2. Execute add -c n/aaa.

3. Execute add -c n/AAA a/123.

4. Execute add -c n/bbb a/abc.

5. Execute add -c n/BBB.

6. Execute edit -c 4 a/d.

7. The following order results. Expected result should be 1. AAA, 2. bbb, 3. aaa, 4. BBB.

[nus-se-bot]

Team's Response

This is an expected behaviour. We have also stated in the UG that when adding contacts with missing fields, there will be a placeholder address called "Address not yet added" . These placeholder addresses are considered addresses and will be sorted by alphabetical order. Furthermore, I believe that this is a matter of user preference on whether the contacts with "Address not yet added" placeholders should be all on top or at the bottom. We chose to keep it as a cluster and arrange them alphabetically as if the user is trying to find all users with "address not yet added", they will know where to find them instinctively since they know this command sorts the address by alphabetical order.

Furthermore, this can be solved by the fixing the UG as per a similar issue (4109) that was accepted.

Items for the Tester to Verify

❓ Issue response

Team chose [response.Rejected]

• I disagree

Reason for disagreement: [replace this with your reason]

---

❓ Issue severity

Team chose [severity.Medium]
Originally [severity.High]

• I disagree

Reason for disagreement: [replace this with your reason]

---