Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Contacts without addresses are slotted into list randomly after sorting by address #6

Open
w-yeehong opened this issue Nov 13, 2020 · 1 comment

Comments

@w-yeehong
Copy link
Owner

Expected Outcome

After sorting the list of contacts by address, new contacts without addresses are added to the bottom of the list.

Description

After sorting the list of contacts by address, new contacts without addresses are slotted into the list, possibly randomly. This makes it difficult to locate the newly added entry.

Steps to Reproduce

  1. Execute sort -c 2.

  2. Execute add -c n/aaa.

  3. Execute add -c n/AAA.

  4. Execute add -c n/bbb.

  5. Execute add -c n/BBB.

  6. The following order results. Expected result should be 1. aaa, 2. AAA, 3. bbb, 4. BBB.

image.png

@nus-se-bot
Copy link

Team's Response

This is an expected behaviour. We have also stated in the UG that when adding contacts with missing fields, there will be a placeholder address called "Address not yet added" . These placeholder addresses are considered addresses and will be sorted by alphabetical order. Furthermore, I believe that this is a matter of user preference on whether the contacts with "Address not yet added" placeholders should be all on top or at the bottom. We chose to keep it as a cluster and arrange them alphabetically as if the user is trying to find all users with "address not yet added", they will know where to find them instinctively since they know this command sorts the address by alphabetical order.

Furthermore, this can be solved by the fixing the UG as per a similar issue (4109) that was accepted.

Items for the Tester to Verify

❓ Issue response

Team chose [response.Rejected]

  • I disagree

Reason for disagreement: [replace this with your reason]


❓ Issue severity

Team chose [severity.Medium]
Originally [severity.High]

  • I disagree

Reason for disagreement: [replace this with your reason]


Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants