Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Contacts can be edited even when none of the parameters have been changed #4

Open
w-yeehong opened this issue Nov 13, 2020 · 1 comment

Comments

@w-yeehong
Copy link
Owner

Expected Outcome

Trying to edit a contact with the same details (e.g. Name, Email, ...) should display an error message.

Description

Editing a contact with the same details is considered as successful execution.

Steps to Reproduce

  1. Execute add -c n/aaa.

  2. Execute edit -c 1 n/aaa.

  3. The command is successful.
    image.png

@nus-se-bot
Copy link

Team's Response

This is behaviour inherited from AB3.

inherited.png

It is also consistent with the edit event command.

Before changing the description:

edit event before.png

After changing to the same description:

edit event after.png

We essentially allow users to set whatever they want for that specific contact's fields even if they are the same as before.

Severity has been changed to low as attempted edits to the same field does not seem like it would occur very often.

severity.png

Items for the Tester to Verify

❓ Issue response

Team chose [response.Rejected]

  • I disagree

Reason for disagreement: [replace this with your reason]


❓ Issue severity

Team chose [severity.Low]
Originally [severity.Medium]

  • I disagree

Reason for disagreement: [replace this with your reason]


Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants