Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MAX_INT triggers invalid command error message instead of invalid index #3

Open
w-yeehong opened this issue Nov 13, 2020 · 1 comment

Comments

@w-yeehong
Copy link
Owner

w-yeehong commented Nov 13, 2020

Expected Outcome

The error message The person index provided is invalid appears for values that exceed MAX_INT.

Description

The error message Invalid command format! is displayed for values that exceed MAX_INT.

Steps to Reproduce

  1. Execute delete -c 10000000000

  2. The following error message is displayed.
    image.png

@nus-se-bot
Copy link

nus-se-bot commented Nov 18, 2020

Team's Response

Inherited from AB3. Rejected as per prof instructions here:
https://github.com/nus-cs2103-AY2021S1/forum/issues

Items for the Tester to Verify

❓ Issue response

Team chose [response.Rejected]

  • I disagree

Reason for disagreement: Hello, thank you for your response.

AB3 does indeed have the same issue. That said, I think you could fix the incorrect error message when adding the -c flag for deletion of contacts. Moreover, I gave an example using delete -c, but the other delete commands such as delete -e face the same issue and those commands are not in AB3. I think that it should not be considered a bug inherited from AB3.


Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants