Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

do_CONNECT filter is not working #517

Open
osxtest opened this issue Jun 18, 2022 · 0 comments
Open

do_CONNECT filter is not working #517

osxtest opened this issue Jun 18, 2022 · 0 comments

Comments

@osxtest
Copy link
Contributor

osxtest commented Jun 18, 2022

Hi, I noticed that at code https://github.com/w-digital-scanner/w13scan/blob/master/W13SCAN/lib/proxy/baseproxy.py#L423-L450 you are trying to relay some HTTPS requests directly accroding to the extension in the CONNECT request, but it looks like it will not going to work, because the CONNECT request does not contain any extension information.

reproduce

  1. run python3 w13scan.py -s 127.0.0.1:8081
  2. use 127.0.0.1:8081 proxy at your browser
  3. visit https://www.baidu.com/favicon.ico
  4. check the browser certificate
  5. you will see W13scan cert instead baidu cert
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@osxtest