New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove suggestion to underscore internal function paramaters #79

Open

spinoch opened this issue Nov 13, 2020 · 0 comments

spinoch commented Nov 13, 2020

The convention to add an underscore to the parameter names of internal function was removed in vyper in vyperlang/vyper#2166

Thus, this no longer applies and we should remove this statement in https://github.com/vyperfun/vyper.fun/blob/master/1/external_internal_functions.md .
Note that this does not affect internal function names, only their parameter names.

At the time of writing this however, due to a bug in vyper this still fails for function arguments, although it is fine for local variable names.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment