Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tests silently skipped in CI on Windows and macOS environment #1877

Open
Neo-Zhixing opened this issue Apr 15, 2022 · 1 comment
Open

Tests silently skipped in CI on Windows and macOS environment #1877

Neo-Zhixing opened this issue Apr 15, 2022 · 1 comment

Comments

@Neo-Zhixing
Copy link

Neo-Zhixing commented Apr 15, 2022

Turns out the GitHub actions Windows and macOS environment does not have Vulkan installed. That make sense - macOS don't generally have MoltenVK installed.

Err(_) => return,

Right now during tests, if we fail to load the vulkan library, or if instance creation fails for any reason, it simply returns from the test and mark it as success.

We should probably figure out a way to install Vulkan environment on Windows & macOS.

#1841 (comment)
#1876 (comment)

@Rua
Copy link
Contributor

Rua commented Apr 15, 2022

Pinging @AustinJ235 who commented on the issue previously.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants