Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Syntax highlighting on GitHub doesn't work for vue when optional chaining is used #3827

Closed
hfhchan-plb opened this issue Dec 27, 2023 · 3 comments
Labels
need transfer question Further information is requested

Comments

@hfhchan-plb
Copy link

This issue exists in @vuejs/vue-syntax-highlight. See vuejs/vue-syntax-highlight#217 for description of the bug.

@Juicetan
Copy link

+1 this has been bugging me quite a bit

@davidmatter
Copy link
Collaborator

@johnsoncodehk should linguist point to the tmlanguage definition of this repo? Seems https://github.com/vuejs/vue-syntax-highlight is 5 years behind. @hfhchan-plb @Juicetan feel free to create a PR at https://github.com/vuejs/vue-syntax-highlight to update it with https://github.com/vuejs/language-tools/blob/master/extensions/vscode/syntaxes/vue.tmLanguage.json

@davidmatter davidmatter added question Further information is requested need transfer labels Jul 7, 2024
@yuichkun
Copy link

@johnsoncodehk should linguist point to the tmlanguage definition of this repo? Seems https://github.com/vuejs/vue-syntax-highlight is 5 years behind. @hfhchan-plb @Juicetan feel free to create a PR at https://github.com/vuejs/vue-syntax-highlight to update it with https://github.com/vuejs/language-tools/blob/master/extensions/vscode/syntaxes/vue.tmLanguage.json

FYI: I made a PR on linguist and it's approved now. They won't ship it until the next release though

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
need transfer question Further information is requested
Projects
None yet
Development

No branches or pull requests

5 participants