From d4c32e43fd430fb5db71f446b4b2fc35e0ed5439 Mon Sep 17 00:00:00 2001 From: Thanh Nguyen Date: Mon, 7 Sep 2020 16:09:41 +0700 Subject: [PATCH 1/2] fix: defensive checking in reviver function #1186 --- packages/shared-utils/src/util.js | 3 +++ 1 file changed, 3 insertions(+) diff --git a/packages/shared-utils/src/util.js b/packages/shared-utils/src/util.js index ddecd3d0b..31f759ddf 100644 --- a/packages/shared-utils/src/util.js +++ b/packages/shared-utils/src/util.js @@ -372,6 +372,9 @@ function reviver (key, val) { return Symbol.for(string) } else if (specialTypeRE.test(val)) { const [, type, string] = specialTypeRE.exec(val) + if (!window[type]){ + return undefined + } return new window[type](string) } else { return val From b3e8c65f6b4848c69f6d52fe87214c04dbae14b0 Mon Sep 17 00:00:00 2001 From: Thanh Nguyen Date: Mon, 7 Sep 2020 16:34:16 +0700 Subject: [PATCH 2/2] linting --- packages/shared-utils/src/util.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/packages/shared-utils/src/util.js b/packages/shared-utils/src/util.js index 31f759ddf..3efe0250a 100644 --- a/packages/shared-utils/src/util.js +++ b/packages/shared-utils/src/util.js @@ -372,7 +372,7 @@ function reviver (key, val) { return Symbol.for(string) } else if (specialTypeRE.test(val)) { const [, type, string] = specialTypeRE.exec(val) - if (!window[type]){ + if (!window[type]) { return undefined } return new window[type](string)