Skip to content

Commit 675791f

Browse files
committed
fix: rebase
1 parent c43a911 commit 675791f

File tree

176 files changed

+7650
-5012
lines changed

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

176 files changed

+7650
-5012
lines changed

.eslintrc.js

+7-2
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,7 @@ module.exports = {
66
parserOptions: {
77
sourceType: 'module'
88
},
9-
plugins: ["jest"],
9+
plugins: ['jest'],
1010
rules: {
1111
'no-debugger': 'error',
1212
'no-unused-vars': [
@@ -72,7 +72,12 @@ module.exports = {
7272
},
7373
// Node scripts
7474
{
75-
files: ['scripts/**', './*.js', 'packages/**/index.js', 'packages/size-check/**'],
75+
files: [
76+
'scripts/**',
77+
'./*.js',
78+
'packages/**/index.js',
79+
'packages/size-check/**'
80+
],
7681
rules: {
7782
'no-restricted-globals': 'off',
7883
'no-restricted-syntax': 'off'

.github/contributing.md

+37-26
Original file line numberDiff line numberDiff line change
@@ -36,9 +36,9 @@ Hi! I'm really excited that you are interested in contributing to Vue.js. Before
3636

3737
- Make sure tests pass!
3838

39-
- Commit messages must follow the [commit message convention](./commit-convention.md) so that changelogs can be automatically generated. Commit messages are automatically validated before commit (by invoking [Git Hooks](https://git-scm.com/docs/githooks) via [yorkie](https://github.com/yyx990803/yorkie)).
39+
- Commit messages must follow the [commit message convention](./commit-convention.md) so that changelogs can be automatically generated. Commit messages are automatically validated before commit (by invoking [Git Hooks](https://git-scm.com/docs/githooks) via [simple-git-hooks](https://github.com/toplenboren/simple-git-hooks)).
4040

41-
- No need to worry about code style as long as you have installed the dev dependencies - modified files are automatically formatted with Prettier on commit (by invoking [Git Hooks](https://git-scm.com/docs/githooks) via [yorkie](https://github.com/yyx990803/yorkie)).
41+
- No need to worry about code style as long as you have installed the dev dependencies - modified files are automatically formatted with Prettier on commit (by invoking [Git Hooks](https://git-scm.com/docs/githooks) via [simple-git-hooks](https://github.com/toplenboren/simple-git-hooks)).
4242

4343
### Advanced Pull Request Tips
4444

@@ -47,6 +47,7 @@ Hi! I'm really excited that you are interested in contributing to Vue.js. Before
4747
- Consider the performance / size impact of the changes, and whether the bug being fixes justifies the cost. If the bug being fixed is a very niche edge case, we should try to minimize the size / perf cost to make it worthwhile.
4848

4949
- Is the code perf-sensitive (e.g. in "hot paths" like component updates or the vdom patch function?)
50+
5051
- If the branch is dev-only, performance is less of a concern.
5152

5253
- Check how much extra bundle size the change introduces.
@@ -77,6 +78,8 @@ A high level overview of tools used:
7778

7879
**The examples below will be using the `nr` command from the [ni](https://github.com/antfu/ni) package.** You can also use plain `npm run`, but you will need to pass all additional arguments after the command after an extra `--`. For example, `nr build runtime --all` is equivalent to `npm run build -- runtime --all`.
7980

81+
The `run-s` and `run-p` commands found in some scripts are from [npm-run-all](https://github.com/mysticatea/npm-run-all) for orchestrating multiple scripts. `run-s` means "run in sequence" while `run-p` means "run in parallel".
82+
8083
### `nr build`
8184

8285
The `build` script builds all public packages (packages without `private: true` in their `package.json`).
@@ -152,9 +155,17 @@ $ nr dev
152155

153156
- The `dev` script supports the `-i` flag for inlining all deps. This is useful when debugging `esm-bundler` builds which externalizes deps by default.
154157

158+
### `nr dev-sfc`
159+
160+
Shortcut for starting the SFC Playground in local dev mode. This provides the fastest feedback loop when debugging issues that can be reproduced in the SFC Playground.
161+
162+
### `nr dev-esm`
163+
164+
Builds and watches `vue/dist/vue-runtime.esm-bundler.js` with all deps inlined using esbuild. This is useful when debugging the ESM build in a reproductions that require real build setups: link `packages/vue` globally, then link it into the project being debugged.
165+
155166
### `nr dev-compiler`
156167

157-
The `dev-compiler` script builds, watches and serves the [Template Explorer](https://github.com/vuejs/core/tree/main/packages/template-explorer) at `http://localhost:5000`. This is extremely useful when working on the compiler.
168+
The `dev-compiler` script builds, watches and serves the [Template Explorer](https://github.com/vuejs/core/tree/main/packages/template-explorer) at `http://localhost:5000`. This is useful when working on pure compiler issues.
158169

159170
### `nr test`
160171

@@ -222,27 +233,29 @@ This is made possible via several configurations:
222233

223234
### Package Dependencies
224235

225-
```
226-
+---------------------+
227-
| |
228-
| @vue/compiler-sfc |
229-
| |
230-
+-----+--------+------+
231-
| |
232-
v v
233-
+---------------------+ +----------------------+
234-
| | | |
235-
+------------>| @vue/compiler-dom +--->| @vue/compiler-core |
236-
| | | | |
237-
+----+----+ +---------------------+ +----------------------+
238-
| |
239-
| vue |
240-
| |
241-
+----+----+ +---------------------+ +----------------------+ +-------------------+
242-
| | | | | | |
243-
+------------>| @vue/runtime-dom +--->| @vue/runtime-core +--->| @vue/reactivity |
244-
| | | | | |
245-
+---------------------+ +----------------------+ +-------------------+
236+
```mermaid
237+
flowchart LR
238+
compiler-sfc["@vue/compiler-sfc"]
239+
compiler-dom["@vue/compiler-dom"]
240+
compiler-core["@vue/compiler-core"]
241+
vue["vue"]
242+
runtime-dom["@vue/runtime-dom"]
243+
runtime-core["@vue/runtime-core"]
244+
reactivity["@vue/reactivity"]
245+
246+
subgraph "Runtime Packages"
247+
runtime-dom --> runtime-core
248+
runtime-core --> reactivity
249+
end
250+
251+
subgraph "Compiler Packages"
252+
compiler-sfc --> compiler-core
253+
compiler-sfc --> compiler-dom
254+
compiler-dom --> compiler-core
255+
end
256+
257+
vue ---> compiler-dom
258+
vue --> runtime-dom
246259
```
247260

248261
There are some rules to follow when importing across package boundaries:
@@ -267,8 +280,6 @@ Test coverage is continuously deployed at https://vue-next-coverage.netlify.app/
267280

268281
### Testing Type Definition Correctness
269282

270-
This project uses [tsd](https://github.com/SamVerschueren/tsd) to test the built definition files (`*.d.ts`).
271-
272283
Type tests are located in the `test-dts` directory. To run the dts tests, run `nr test-dts`. Note that the type test requires all relevant `*.d.ts` files to be built first (and the script does it for you). Once the `d.ts` files are built and up-to-date, the tests can be re-run by simply running `nr test-dts`.
273284

274285
## Financial Contribution

.github/workflows/ci.yml

+21-12
Original file line numberDiff line numberDiff line change
@@ -17,15 +17,15 @@ jobs:
1717
- uses: actions/checkout@v3
1818

1919
- name: Install pnpm
20-
uses: pnpm/action-setup@v3
20+
uses: pnpm/action-setup@v2
2121

22-
- name: Set node version to 16
22+
- name: Set node version to 18
2323
uses: actions/setup-node@v3
2424
with:
25-
node-version: 16
25+
node-version: 18
2626
cache: 'pnpm'
2727

28-
- run: pnpm install
28+
- run: PUPPETEER_SKIP_DOWNLOAD=1 pnpm install
2929

3030
- name: Run unit tests
3131
run: pnpm run test-unit
@@ -35,13 +35,19 @@ jobs:
3535
steps:
3636
- uses: actions/checkout@v3
3737

38+
- name: Setup cache for Chromium binary
39+
uses: actions/cache@v3
40+
with:
41+
path: ~/.cache/puppeteer/chrome
42+
key: chromium-${{ hashFiles('pnpm-lock.yaml') }}
43+
3844
- name: Install pnpm
3945
uses: pnpm/action-setup@v2
4046

41-
- name: Set node version to 16
47+
- name: Set node version to 18
4248
uses: actions/setup-node@v3
4349
with:
44-
node-version: 16
50+
node-version: 18
4551
cache: 'pnpm'
4652

4753
- run: pnpm install
@@ -57,17 +63,20 @@ jobs:
5763
- name: Install pnpm
5864
uses: pnpm/action-setup@v2
5965

60-
- name: Set node version to 16
66+
- name: Set node version to 18
6167
uses: actions/setup-node@v3
6268
with:
63-
node-version: 16
69+
node-version: 18
6470
cache: 'pnpm'
6571

66-
- run: pnpm install
72+
- run: PUPPETEER_SKIP_DOWNLOAD=1 pnpm install
6773

6874
- name: Run eslint
6975
run: pnpm run lint
7076

77+
# - name: Run prettier
78+
# run: pnpm run format-check
79+
7180
- name: Run type declaration tests
7281
run: pnpm run test-dts
7382

@@ -81,13 +90,13 @@ jobs:
8190
- name: Install pnpm
8291
uses: pnpm/action-setup@v2
8392

84-
- name: Set node version to 16
93+
- name: Set node version to 18
8594
uses: actions/setup-node@v3
8695
with:
87-
node-version: 16
96+
node-version: 18
8897
cache: 'pnpm'
8998

90-
- run: pnpm install
99+
- run: PUPPETEER_SKIP_DOWNLOAD=1 pnpm install
91100
- run: pnpm run size
92101

93102
# - name: Check build size

.prettierignore

+1
Original file line numberDiff line numberDiff line change
@@ -0,0 +1 @@
1+
dist

BACKERS.md

+1-1
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
<h1 align="center">Sponsors &amp; Backers</h1>
22

3-
Vue.js is an MIT-licensed open source project with its ongoing development made possible entirely by the support of the awesome sponsors and backers listed in this file. If you'd like to join them, please consider [ sponsor Vue's development](https://vuejs.org/sponsor/).
3+
Vue.js is an MIT-licensed open source project with its ongoing development made possible entirely by the support of the awesome sponsors and backers listed in this file. If you'd like to join them, please consider [ sponsoring Vue's development](https://vuejs.org/sponsor/).
44

55
<p align="center">
66
<a target="_blank" href="https://sponsors.vuejs.org/backers.svg">

0 commit comments

Comments
 (0)