Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Accessibility fix: Add aria-role to search input combobox #2134

Open
erinmorrissey-hearst opened this issue Nov 29, 2023 · 1 comment
Open

Accessibility fix: Add aria-role to search input combobox #2134

erinmorrissey-hearst opened this issue Nov 29, 2023 · 1 comment
Labels
bug Something isn't working

Comments

@erinmorrissey-hearst
Copy link

Describe the bug
An accessiblity audit that we ran found a critical-level issue with the search input box that looks like a quick fix in the SearchInputField component:

axeauditor dequecloud com_test-run_71fdc64a-7df3-11ee-baa1-3fffa325a650_issue_6d0ffeb2-7f99-11ee-bc90-b7d4257deccf_activeTab=dt-issue page=0 pageSize=50 sortField=ordinal sortDir=asc filter%5Bseverity%5D=4 filter%5Btype%5D=issue row=38 issu

Screenshot 2023-11-29 at 11 40 53 AM

Screenshot 2023-11-29 at 11 41 06 AM

Possible Solution
Add appropriate aria-role to search input combobox
@erinmorrissey-hearst erinmorrissey-hearst added the bug Something isn't working label Nov 29, 2023
@hellofanny
Copy link
Contributor

Thanks for reporting! I'll take a look into 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@hellofanny @erinmorrissey-hearst