Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: advertisement options #475

Merged
merged 3 commits into from
Jul 9, 2024
Merged

Feature: advertisement options #475

merged 3 commits into from
Jul 9, 2024

Conversation

hcaula
Copy link
Contributor

@hcaula hcaula commented Jul 2, 2024

What problem is this solving?

Passes the new information from advertisementOptions to Intelligent Search API.

Checklist/Reminders

  • Updated README.md.
  • Updated CHANGELOG.md.
  • Linked this PR to a Clubhouse story (if applicable).
  • Updated/created tests (important for bug fixes).
  • Deleted the workspace after merging this PR (if applicable).

Type of changes

✔️ Type of Change
_ Bug fix
✔️ New feature
_ Breaking change
_ Technical improvements

@hcaula hcaula requested review from luarakerlen and hiagolcm July 2, 2024 21:23
@hcaula hcaula self-assigned this Jul 2, 2024
Copy link

vtex-io-ci-cd bot commented Jul 2, 2024

Hi! I'm VTEX IO CI/CD Bot and I'll be helping you to publish your app! 🤖

Please select which version do you want to release:

  • Patch (backwards-compatible bug fixes)

  • Minor (backwards-compatible functionality)

  • Major (incompatible API changes)

And then you just need to merge your PR when you are ready! There is no need to create a release commit/tag.

  • No thanks, I would rather do it manually 😞

@vtex-io-docs-bot
Copy link

vtex-io-docs-bot bot commented Jul 2, 2024

Beep boop 🤖

I noticed you didn't make any changes at the docs/ folder

  • There's nothing new to document 🤔
  • I'll do it later 😞

In order to keep track, I'll create an issue if you decide now is not a good time

  • I just updated 🎉🎉

@hcaula hcaula force-pushed the feat/advertisement-options branch from df841b5 to 1a13796 Compare July 2, 2024 21:25
@hcaula hcaula merged commit 434d170 into v1.x Jul 9, 2024
4 of 8 checks passed
@hcaula hcaula deleted the feat/advertisement-options branch July 9, 2024 13:14
Copy link

vtex-io-ci-cd bot commented Jul 9, 2024

Your PR has been merged! App is being published. 🚀
Version 1.70.0 → 1.71.0

After the publishing process has been completed (check #vtex-io-releases) and doing A/B tests with the new version, you can deploy your release by running:

vtex deploy [email protected]

After that your app will be updated on all accounts.

For more information on the deployment process check the docs. 📖

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants