Skip to content

Commit

Permalink
Merge pull request #20 from vtex-apps/feature/v1-tax-prices
Browse files Browse the repository at this point in the history
Added stub implementation for taxPercentage
  • Loading branch information
chrsmutti authored May 8, 2020
2 parents 2160263 + b22b724 commit bccb728
Show file tree
Hide file tree
Showing 4 changed files with 9 additions and 6 deletions.
2 changes: 2 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,8 @@ The format is based on [Keep a Changelog](http://keepachangelog.com/en/1.0.0/)
and this project adheres to [Semantic Versioning](http://semver.org/spec/v2.0.0.html).

## [Unreleased]
### Added
- `taxPercentage` stub resolver on `Offer`.

## [1.1.2] - 2020-05-07

Expand Down
4 changes: 2 additions & 2 deletions node/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -31,8 +31,8 @@
"ramda": "^0.26.1",
"slugify": "^1.2.6",
"typescript": "3.8.3",
"vtex.search-graphql": "http://vtex.vtexassets.com/_v/public/typings/v1/[email protected]/public",
"unescape": "^1.0.1"
"unescape": "^1.0.1",
"vtex.search-graphql": "http://vtex.vtexassets.com/_v/public/typings/v1/[email protected]/public"
},
"devDependencies": {
"@types/atob": "^2.1.2",
Expand Down
3 changes: 2 additions & 1 deletion node/resolvers/search/offer.ts
Original file line number Diff line number Diff line change
Expand Up @@ -102,6 +102,7 @@ export const resolvers = {
return (NumberOfInstallments === 1 && Value < sellingPrice)
})?.Value;
return spotPrice || sellingPrice
}
},
taxPercentage: () => 0 // NOTE: We do not have offer.Tax info
},
}
6 changes: 3 additions & 3 deletions node/yarn.lock
Original file line number Diff line number Diff line change
Expand Up @@ -4839,7 +4839,7 @@ static-extend@^0.1.1:
define-property "^0.2.5"
object-copy "^0.1.0"

"stats-lite@github:vtex/node-stats-lite#dist":
stats-lite@vtex/node-stats-lite#dist:
version "2.2.0"
resolved "https://codeload.github.com/vtex/node-stats-lite/tar.gz/1b0d39cc41ef7aaecfd541191f877887a2044797"
dependencies:
Expand Down Expand Up @@ -5416,9 +5416,9 @@ [email protected]:
core-util-is "1.0.2"
extsprintf "^1.2.0"

"vtex.search-graphql@http://vtex.vtexassets.com/_v/public/typings/v1/[email protected].0-beta.0/public":
"vtex.search-graphql@http://vtex.vtexassets.com/_v/public/typings/v1/[email protected].2-beta.0/public":
version "0.0.0"
resolved "http://vtex.vtexassets.com/_v/public/typings/v1/[email protected].0-beta.0/public#9792d7bdb757d0589ca11444acf72079273425b2"
resolved "http://vtex.vtexassets.com/_v/public/typings/v1/[email protected].2-beta.0/public#5426ea5d6dedc54d790646c92696a944d454a603"

w3c-hr-time@^1.0.1:
version "1.0.1"
Expand Down

0 comments on commit bccb728

Please sign in to comment.