Rename of vsg::UniformBinding to vsg::DescriptorBinding and associated method renaming/deprecation #964
robertosfield
started this conversation in
General
Replies: 1 comment 1 reply
-
I noticed that this PR renames the
|
Beta Was this translation helpful? Give feedback.
1 reply
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
-
Hi All,
I have just merged changes to VSG master that renames vsg::UniformBinding to vsg::DescriptorBinding and also renames a collection of enableUniform(..)/assignUniform(..) methods in vsg;;DescriptorConfiguration and vsg::GraphicsPipelineConfigurator to enbleDesciptor/enableDescriptor(..). The original methods have been [[deprecated]] so you'll now get warnings to rename them when you build against VSG master or the next stable release 1.0.10.
The changes to the VSG are:
#963
The deprecated methods were used in vsgXchange, vsgPoints and vsgExamples so I have merged changes to them to update them to the lastest API. Changes are just renames of methods/classes so it's not a major task:
vsg-dev/vsgXchange#169
vsg-dev/vsgPoints#14
vsg-dev/vsgExamples#262
These changes were made to resolve some clumsy naming of class and methods which was highlighted when @theodoregoetz recently tried to use ShaderSet/GraphicsPipelineConfigurator with a DescruptorBuffer set up as storage buffer type rather than a uniform buffer. type that these classes had been designed around. The new naming is more general purpose.
Thanks to @theodoregoetz helping out with these changes and making fixes to the storage buffer support.
Beta Was this translation helpful? Give feedback.
All reactions