Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chunks are not valid #510

Open
maskalix opened this issue Oct 8, 2024 · 18 comments
Open

Chunks are not valid #510

maskalix opened this issue Oct 8, 2024 · 18 comments
Labels
addressed bug Something isn't working
Milestone

Comments

@maskalix
Copy link

maskalix commented Oct 8, 2024

Obsidian-c22184a33dad4e21:10/8/2024, 9:51:09 PM->Chunks of .obsidian/plugins/obsidian-tasks-plugin/styles.css (i:f:c5c7) are not valid.

or for any .md file too. Just chunks of are not valid.
What should i do?

@gabrielnegreira
Copy link

Same issue here.

@0vermind
Copy link

+1

@ceisma
Copy link

ceisma commented Oct 10, 2024

Yep, same problem here. Was trying to sync a new device. Would like to know how to fix this, or if this is a bug.

@paaradiso
Copy link

+1

4 similar comments
@MementoMornings
Copy link

+1

@Synetic87
Copy link

+1

@repryty
Copy link

repryty commented Oct 12, 2024

+1

@Chriveloper
Copy link

+1

@Chriveloper
Copy link

I have the same issue.
I noticed that when creating a file on my phone example.md with the content "dummy text", then replicating it creates a entry example.md in the db, the entry children points to an id, which was not created. The issue is, that the children is not created in the db. but somehow it works perfectly on my pc

@vrtmrz
Copy link
Owner

vrtmrz commented Oct 14, 2024

Thank you for opening the Issue!
I am so sorry for the inconvenience!
There seems to be a problem with chunks not being sent properly these days. This is being addressed.

However, the code is in a position of not in to released it immediately, so let me introduce a workaround.

  1. Please make missing chunks again on all of your devices. This can be performed on the Hatch pane -> Recreate missing chunks of all files.
    Screenshot_20241015_004734_Obsidian~2

  2. Resend these chunks again. This can be performed on the Maintenance pane -> Resend
    Screenshot_20241015_004800_Obsidian~2

  3. Replicate once and restart Obsidian.

The above steps will complement missing chunks each other, and the broken file will be processed again.

@vrtmrz
Copy link
Owner

vrtmrz commented Oct 14, 2024

As Postscript, possibly disabling Send chunks in bulk or enabling Compute revisions of chunks sometimes works. But I am still not sure (So, rewriting and writing tests also this now). Sorry for your inconvenience, let md allow my rough response from the smartphone!

@vrtmrz vrtmrz added bug Something isn't working addressed labels Oct 17, 2024
@vrtmrz vrtmrz added this to the 0.24.0 milestone Oct 17, 2024
@forrany
Copy link

forrany commented Oct 26, 2024

I also encountered this problem, I thought it was my operation mistake that caused my database to be damaged. However, after trying to rebuild, I still couldn't sync, came here and saw the same problem, found that the plugin might have a bug, hope to fix it as soon as possible, a very useful plugin, thank the author

@leftchest
Copy link

+1

1 similar comment
@revilo951
Copy link

+1

@vrtmrz vrtmrz added awaiting confirmation and removed bug Something isn't working addressed labels Nov 5, 2024
@vrtmrz
Copy link
Owner

vrtmrz commented Nov 5, 2024

This problem has been fixed at v0.24.0. And, Rebuild everything is the best way bring everything back to fine. Or #510 (comment) will fix the vault.

Would you mind if I ask you to upgrade to the latest version and check the behaviour, please?

@toshohirasawa
Copy link

先ほど 0.24.0 で新規にセットアップしましたが、同様の問題が継続的に発生しています。
構成は Macbook Pro (primary) + iPhone (secondary) で、問題は iPhone 側の初回の同期で発生します。

試したこと(ただ、あれこれ試しながらなので、厳密に切り分けはしてません)

  1. primary から Recreate all ➜ Resend (Send chunks): 状況変わらず
  2. End-to-End Encryption を無効化: secondary での同期ができるようになった

一旦 E2E 暗号化は無効にして使用しようと思いますが、なにかお手伝いできることがあればお知らせください。


I still have this problem with the 0.24.0 version on my Macbook (primary) and iPhone (secondary).
The workaround of disabling the "End-to-End encryption" functionality temporarily resolved my problem.

@vrtmrz
Copy link
Owner

vrtmrz commented Nov 7, 2024

ご報告ありがとうございます、0.24.0でも発生していましたか…
最初の同期で発生するのは少し納得がいきますね。Recreateしても、作成順は変わらないので、これは初回同期の修正には役立たないかもしれません。ご案内ミスですね。本来はRebuild everythingが必要だったのだと思います。ただ、微妙なところで、Fetch chunks on demandがちゃんと待ってない可能性もあるのかも。。

おそらくE2EEを無効化したタイミングでRebuild Everythingをしているので、それでようやくDBの整合性が合った可能性もあります。
なので、再度E2EEを有効にしても(また Rebuild Everythingされるので)問題無く同期できると思いますが、対策として、チャンク収集部分を少し修正してみようと思います。

また、状況が良くなった際には告知しますので、よろしくお願いいたします。


Thank you for reporting this! So sorry to hear that it have been still occur in 0.24.0...
It makes a bit of sense that it would happen on the first sync - Recreate doesn't change the order of creation, so this may not help to correct the initial synchronisation. My guidance error. I think we originally needed to Rebuild everything. However, in a subtle way, it is possible that Fetch chunks on demand may not be waiting properly.

Perhaps you did a Rebuild at the time you disabled E2EE, so it is possible that that is how you finally got the DB to be consistent.
So I think I can synchronise without problems even if I enable E2EE again, but as a countermeasure, I will try to modify the chunk collection part a little.

I will notify you when the situation improves.

@vrtmrz vrtmrz added bug Something isn't working addressed and removed awaiting confirmation labels Nov 7, 2024
@maskalix
Copy link
Author

maskalix commented Nov 7, 2024

This problem has been fixed at v0.24.0. And, Rebuild everything is the best way bring everything back to fine. Or #510 (comment) will fix the vault.

Would you mind if I ask you to upgrade to the latest version and check the behaviour, please?

Did, works better but still, doesn't sync all the files... Don't know why tho

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
addressed bug Something isn't working
Projects
None yet
Development

No branches or pull requests