Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docker building failing #54

Open
garciagenrique opened this issue Aug 12, 2024 · 0 comments
Open

Docker building failing #54

garciagenrique opened this issue Aug 12, 2024 · 0 comments

Comments

@garciagenrique
Copy link
Member

See actions output

I see two ways of fixing this:

  • Either returning to the old way of tagging - therefore we won't have the docker images build including the changes of the PR (what imo is not super fundamental as we are reaching the end of the "dev" period),
  • Either implement something like this... what might be a bit more complicated to maintain:
- name: Set image tags
  id: set-tags
  run: |
    if [[ "${{ github.event_name }}" == "pull_request" ]]; then
      echo "tags=${{ env.REGISTRY }}/${{ env.IMAGE_NAME }}:dev" >> $GITHUB_ENV
    elif [[ "${{ github.event_name }}" == "release" ]]; then
      echo "tags=${{ env.REGISTRY }}/${{ env.IMAGE_NAME }}:${{ github.event.release.tag_name }}" >> $GITHUB_ENV
    elif [[ "${{ github.event_name }}" == "push" && "${{ github.ref_type }}" == "tag" ]]; then
      echo "tags=${{ env.REGISTRY }}/${{ env.IMAGE_NAME }}:${{ github.ref }},${{ env.REGISTRY }}/${{ env.IMAGE_NAME }}:latest" >> $GITHUB_ENV
    else
      echo "tags=${{ env.REGISTRY }}/${{ env.IMAGE_NAME }}:sha-${{ github.sha }},${{ env.REGISTRY }}/${{ env.IMAGE_NAME }}:latest" >> $GITHUB_ENV

Listening to your comments @mrzengel and @Soap2G ! :D

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant