Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Question Regarding the upgrade path of the package #23

Open
3 tasks done
ParasGarg7 opened this issue Jun 20, 2024 · 0 comments
Open
3 tasks done

Question Regarding the upgrade path of the package #23

ParasGarg7 opened this issue Jun 20, 2024 · 0 comments

Comments

@ParasGarg7
Copy link

ParasGarg7 commented Jun 20, 2024

Description

Hey, great package and was looking to integrate it into one of my projects.
Just have a small question regarding the value of AESIV and AESKey.
I noticed that in the latest version of the package (1.2.2), the values of these were changed as below
SecureDefaults.AESIV -> SecureDefaults.v1.2.2.AESIV
SecureDefaults.AESKey -> SecureDefaults.v1.2.2.AESKey

I just want to understand that are you planning to change it in every version to a newer value, based upon the version of the package.
If so, then i believe this would cause the key AESIV to be not found in the Keychain and thus causing a behaviour wherein the migrating between versions of SecureDefaults will cause the values stored in UserDefaults to not be found.
For eg, I started with the version 1.2.1 and then built the app.
Then when the version was upgraded to 1.2.2, then the var isKeyCreated gave false, becase _key could not be found in the Keychain, thus causing all the UserDefaults to be not accessible.

If the plan is something else, I would love to contribute to the same.

Requirements (place an x in each of the [ ])

  • I've read and agree to the Code of Conduct.
  • I've read and understood the Contributing guidelines and have done my best effort to follow them.
  • I've searched for any related issues and avoided creating a duplicate issue.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant