Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Max height on session replay #96

Open
HugoGresse opened this issue May 13, 2024 · 2 comments
Open

Max height on session replay #96

HugoGresse opened this issue May 13, 2024 · 2 comments

Comments

@HugoGresse
Copy link

When opening the given website: https://app-demo.voxxr.in/events/devoxxfr2024/talks/50192/details
The youtube video is taking 100vw, it could be great to also add a maxHeight like 50vh so the video control are actually display in above the fold.

@fcamblor
Copy link
Collaborator

Hello Hugo, I'm not sure to follow your point.

What are controls that are getting in the way currently ?
"More videos" button ? Talk header with title ? Other controls ?
Voxxrin_-_Your_conference_companion

I'm asking because all these controls disappear automatically after playing the video during ~3s
Cursor_and_Voxxrin_-_Your_conference_companion

Putting a max-height: 50vh on the iframe element doesn't change anything on my side, but putting a height: 50vh pushes bottom controls at a cost of a higher "lost space" once control disappear (after 3s)
Cursor_and_Voxxrin_-_Your_conference_companion

=> Not sure if this is worth it, but I might misunderstand your point.

Note that I'm currently using an aspect-ratio: 4/3 property as I consider this format fits well to incorporate controls into 16:9 videos.

@HugoGresse
Copy link
Author

I think it's for the desktop use case, though Voxxrin may not fit in this case?

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants