Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updating webhook-go package #671

Open
gvde opened this issue Dec 12, 2024 · 3 comments
Open

Updating webhook-go package #671

gvde opened this issue Dec 12, 2024 · 3 comments

Comments

@gvde
Copy link

gvde commented Dec 12, 2024

I have just pulled puppet-r10k version 14.0.0 to our puppet servers. Running the updated modules it doesn't seem to update the webhook-go package to 2.8.0 even though I thought it should do so according to the changelog. As far as I can see r10k::webhook::package it only ensures that webhook-go is installed but not which version. Or am I missing something?

Affected Puppet, Ruby, OS and module versions/distributions

  • Puppet: 8.10.0
  • Ruby: ruby-3.0.7-162.el9_4.x86_64
  • Distribution: AlmaLinux 9.5
  • Module version: 14.0.0

How to reproduce (e.g Puppet code you use)

Using 13.0.0 with webhook-go 2.2.0 and then updating the module to 14.0.0.

@saz
Copy link
Contributor

saz commented Dec 15, 2024

The package resource has ensure => present set. Setting it to ensure => latest, manually removing the file /tmp/webhook-go.rpm and triggering a puppet run will upgrade the package to 2.8.0.

The file in /tmp won't be updated, as soon as it's downloaded once. This might be solved by adding a checksum (obviously, those differ for rpm and deb packages) or adding a version number to the file name.

@T0bl
Copy link

T0bl commented Dec 19, 2024

had the same issue, i think a better option is ${r10k::webhook::version} and not latest.

@saz
Copy link
Contributor

saz commented Dec 19, 2024

The package resource won't do much, if there's no newer package downloaded first. Both latest and the version should help, as long as the first issue has been resolved.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants