Non idempotence for 8 PHP extensions: apcu, ctype, dom, iconv, imagick, posix, xmlreader, xmlwriter

[mfaure]

Affected Puppet, Ruby, OS and module versions/distributions

• Puppet: 5, 6, 6-nightly
• Ruby: 2.5.3
• Distribution: Ubuntu 18.04
• Module version: 7.0.1-rc0

How to reproduce (e.g Puppet code you use)

See:

• WIP Is apcu extension idempotent ? #540 apcu
• WIP Is ctype extension idempotent ? #541 ctype
• WIP Is dom extension idempotent ? #542 dom
• WIP Is iconv extension idempotent ? #543 iconv
• WIP Is imagick extension idempotent ? #544 imagick
• WIP Is posix extension idempotent ? #545 posix
• WIP Is xmlreader extension idempotent ? #546 xmlreader
• WIP Is xmlwriter extension idempotent ? #547 xmlwriter

What are you seeing

Travis acceptance tests are red on test applies idempotently

What behaviour did you expect instead

Travis acceptance tests should be green on applies idempotently

Any additional information you'd like to impart

Context: I'm working to create a component module for NextCloud, which requires a lot of PHP extensions.

It seems those 8 PHP extension (apcu, ctype, dom, iconv, imagick, posix, xmlreader, xmlwriter) are not idempotent on installation, but as I am not a Puppet expert, I'd be really happy to have some feedback.

What I've done:

• Following @Dan33l recommendations, I refactored acceptance tests to clearly separate applies without error test from applies idempotently test. This is done in PR Enhance acceptance tests #539, which is green on all tests. I've also added 6 more extensions (bz2, curl, intl, json, mbstring, zip) to have comparison points.
• Based on Enhance acceptance tests #539, I created 8 new PR (one for each extension) to highlight each extension idempotence status.
  • WIP Is apcu extension idempotent ? #540 apcu
  • WIP Is ctype extension idempotent ? #541 ctype
  • WIP Is dom extension idempotent ? #542 dom
  • WIP Is iconv extension idempotent ? #543 iconv
  • WIP Is imagick extension idempotent ? #544 imagick
  • WIP Is posix extension idempotent ? #545 posix
  • WIP Is xmlreader extension idempotent ? #546 xmlreader
  • WIP Is xmlwriter extension idempotent ? #547 xmlwriter
• For now, I just worked on identifying the issue, and sharing it to gather early feedback. I did not dive in actual code yet.
• In a way, this could be related to Configuration of the apcu-bc extension on Debian fails. #391 but I'm not so sure.

This is my first significant issue reporting, so feel free to correct me, give feedback and point me to suitable documentation if I ever made something wrong :)