Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Members missing from territories #20

Open
aaronrudkin opened this issue Sep 20, 2021 · 5 comments
Open

Members missing from territories #20

aaronrudkin opened this issue Sep 20, 2021 · 5 comments

Comments

@aaronrudkin
Copy link
Member

aaronrudkin commented Sep 20, 2021

We've added votes for the DC, PR, GU, AQ (note: follow up with Jeff about discrepancy between AQ and AS), and VI delegates/representatives from the 103rd forward, none of whom have photos.

In addition, the config/states.json metadata does not support these abbreviations, and so we need to add appropriate mappings for them as well.

Name ICPSR Party Congress State Found?
SAN NICOLAS, Michael 21997 Democratic 116 GU
SABLAN, Gregorio Kilili Camacho 21996 Democratic 116 MP
RADEWAGEN, Aumua Amata Coleman 21995 Republican 116 AQ
PLASKETT, Stacey E. 21994 Democratic 116 VI
NORTON, Eleanor Holmes 21993 Democratic 116 District of Columbia
GONZÁLEZ-CÓLON, Jenniffer 21992 Republican 116 PR
SABLAN, Gregorio Kilili Camacho 91996 Independent 111 MP
PIERLUISI, Pedro 90964 Democratic 111 PR
FALEOMAVAEGA, Eni F. H. 29401 Democratic 111 AQ
PIERLUISI, Pedro 20964 Independent 111 PR
CHRISTENSEN, Donna Marie 20765 Democratic 111 VI
BORDALLO, Madeleine 20764 Democratic 111 GU
FORTUÑO, Luis G. 20766 Republican 110 PR
UNDERWOOD, Robert A. 29403 Democratic 103 GU
ROMERO-BARCELÓ, Carlos A. 29402 Democratic 103 PR
DE LUGO, Ron 29400 Democratic 103 VI
@adamboche
Copy link

adamboche commented Sep 20, 2021 via email

@aaronrudkin
Copy link
Member Author

Thanks for updating AQ to AS, I see that this was congressional weirdness and not me totally losing my mind geographically. Jeff also confirmed that the 103rd is the earliest point where delegates could vote on any rollcall, so in theory this problem is exhaustive and when I close it it, we'll be good to go.

@aaronrudkin
Copy link
Member Author

Added states to state list and got photos for all delegates.

Some notes on the states:

  • for the "vns" field, neither Jeff nor I knew how these were allocated. I allocated AS = 9991, GU = 9992, PR = 9993, VI = 9994.
  • I got FIPS codes from Jeff, these should be standard
  • For ICPSR codes, Jeff dug up incredibly old ICPSR codes; American Samoa and Guam were both assigned 183 in research, so I assigned them 1831 and 1832 here. The Northern Mariana Islands were not assigned anything, but "Trust Territory of the Pacific Islands" had been assigned 185 so I assigned Northern Mariana Islands as 185 here.

I don't actually think any of this matters for the photo side, so I'll revisit this when I do the website side. But just wanted to note how I proceeded.

@JeffreyBLewis
Copy link

We need to check that the 3 and 4-digit ICPSR state codes do not cause misalignment of columns of the generated .ord files which are fixed-width format. If so, we will need to recode state_icpsr with "00" for those cases when generating those files or, perhaps, not follow the icpsr and give them distinct numbers in the nineties.

@adamboche
Copy link

adamboche commented Sep 22, 2021 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants