-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Members missing from territories #20
Comments
FYI, AQ is now AS.
…On Mon, Sep 20, 2021 at 1:31 AM Aaron Rudkin ***@***.***> wrote:
We've added votes for the DC, PR, GU, AQ, and VI delegates/representatives
from the 103rd forward, none of whom have photos.
In addition, the config/states.json metadata does not support these
abbreviations, and so we need to add appropriate mappings for them as well.
Name ICPSR Party Congress State Found?
SAN NICOLAS, Michael 21997 Democratic 116 GU
SABLAN, Gregorio Kilili Camacho 21996 Democratic 116 MP
RADEWAGEN, Aumua Amata Coleman 21995 Republican 116 AQ
PLASKETT, Stacey E. 21994 Democratic 116 VI
NORTON, Eleanor Holmes 21993 Democratic 116 District of Columbia
GONZÁLEZ-CÓLON, Jenniffer 21992 Republican 116 PR
SABLAN, Gregorio Kilili Camacho 91996 Independent 111 MP
PIERLUISI, Pedro 90964 Democratic 111 PR
FALEOMAVAEGA, Eni F. H. 29401 Democratic 111 AQ
PIERLUISI, Pedro 20964 Independent 111 PR
CHRISTENSEN, Donna Marie 20765 Democratic 111 VI
BORDALLO, Madeleine 20764 Democratic 111 GU
FORTUÑO, Luis G. 20766 Republican 110 PR
UNDERWOOD, Robert A. 29403 Democratic 103 GU
ROMERO-BARCELÓ, Carlos A. 29402 Democratic 103 PR
DE LUGO, Ron 29400 Democratic 103 VI
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
<#20>, or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AEXJBC7RPAMJIA5KFAJRFKLUC3WOFANCNFSM5ELNUFIQ>
.
Triage notifications on the go with GitHub Mobile for iOS
<https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675>
or Android
<https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub>.
|
Thanks for updating AQ to AS, I see that this was congressional weirdness and not me totally losing my mind geographically. Jeff also confirmed that the 103rd is the earliest point where delegates could vote on any rollcall, so in theory this problem is exhaustive and when I close it it, we'll be good to go. |
Added states to state list and got photos for all delegates. Some notes on the states:
I don't actually think any of this matters for the photo side, so I'll revisit this when I do the website side. But just wanted to note how I proceeded. |
We need to check that the 3 and 4-digit ICPSR state codes do not cause misalignment of columns of the generated .ord files which are fixed-width format. If so, we will need to recode state_icpsr with "00" for those cases when generating those files or, perhaps, not follow the icpsr and give them distinct numbers in the nineties. |
Jeff is right about the misalignment concern for ORD files. I'm going with
9X for the state_icpsr to avoid problems there. I'm also giving separate
icpsrs to Guam and American Samoa. And following Aaron's pattern above to
give a VNS_id (whatever that is) to the Northern Mariana Islands.
state_name,state_abbrev,state_icpsr,state_fips,vns_ID
AMERICAN SAMOA,AS,93,60,9991
GUAM,GU,94,66,9992
PUERTO RICO,PR,92,72,9993
NORTHERN MARIANA ISLANDS,MP,95,69,9995
VIRGIN ISLANDS,VI,96,78,9994
|
We've added votes for the DC, PR, GU, AQ (note: follow up with Jeff about discrepancy between AQ and AS), and VI delegates/representatives from the 103rd forward, none of whom have photos.
In addition, the
config/states.json
metadata does not support these abbreviations, and so we need to add appropriate mappings for them as well.The text was updated successfully, but these errors were encountered: