Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Generator of links to other members in member biographies is too aggressive #388

Open
JeffreyBLewis opened this issue Feb 7, 2020 · 1 comment

Comments

@JeffreyBLewis
Copy link
Collaborator

For example see,

https://voteview.com/person/99910/george-walker-bush

Here the "George Walker" in "BUSH, George Walker" is linked to a George Walker from Virginia in the late 18th century.

@aaronrudkin
Copy link
Member

Okay, so, I think the initial code for this was way too ambitious and this requires a rethink. We also have not run this script in several years, so of course it's almost moot at this point, but basically here are the design considerations that make me think this should probably be a manual approval situation.

The bug identified in Bush's biography is long since fixed.

This should be a separate helper repo anyway. I'll create a repo for this at some point in the near future and move the issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants