Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support passing in WebSocket implementation #14

Open
paulpdaniels opened this issue Mar 28, 2018 · 1 comment
Open

Support passing in WebSocket implementation #14

paulpdaniels opened this issue Mar 28, 2018 · 1 comment

Comments

@paulpdaniels
Copy link

A lot of implementations that wrap websockets allow passing in a websocket implementation instead of hard coding it. See here and here

Would you consider a PR that includes support for that on the WebSocketTransport. Perhaps via a static create.
@davidwdan
Copy link
Member

Absolutely!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@paulpdaniels @davidwdan