-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: implementation of a pid dp controller #499
Conversation
* chore(pylint): add .pylintrc configuration file * refactor: fix pylint warning W1510 * refactor: fix pylint warning C0116 * refactor: fix pylint warning C0411 * refactor: fix pylint warning R1731 * refactor: fix pylint warning R1705 * refactor: fix pylint warning W1514 * refactor: fix pylint warning C0200 * refactor: fix pylint warning W0611 * refactor: fix pylint warning W0702 * refactor: fix pylint warning C0121 * refactor: fix pylint warning W0107 * refactor: fix pylint warning R1714 * refactor: fix pylint warning C0201 * refactor: fix pylint warning C0303 and W0613 * refactor: fix pylint warning W0621 * refactor: fix pylint warning R0402 * refactor: fix pylint warning W0212 * chore(pylint): update rule adjustments and formatting * style: format code with black * style: format imports with isort * ci: add isort and pylint to Python pipeline * Committing black-format changes * chore: add pyproject.toml for project configuration * ci: update order of pipeline jobs * ci: update pylint job and pylint rules * ci: update which python versions pylint test * ci: update python pipeline to only run on pull_request * refactor: fix pylint warning C0103 * chore: update linting and project configuration rules in .pylintrc and pyproject.toml * Rename files to snake_case * ci: add pipeline for grammar in comments * refactor: fix spelling mistakes in comments * ci: update job codespell_fix to continue on error * refactor: fix spelling mistakes in comments * ci: update pipeline codespell to only have one job * refactor: fix variable naming issues and adjust imports as per review * Committing codespell fixes * refactor: spelling correction * ci: update CI file and job names for consistency * ci: update CI file for more clarity * chore: add codespell configuration and ignore list * chore: add type hints and return types * ci: add mypy.ini for type checking configuration * ci: add mypy type checking workflow * refactor: format code with black * refactor: format all yaml files using prettier * ci: add pipeline for yaml formatting using prettier * ci: update yaml formatting pipeline to run on pull request * refactor: remove deprecated typing * refactor: fix import sorting * ci: remove faulty ci pipelines and combine python pipelines into single file * fix(security): replace subprocess call with safer alternative to remove shell=true * feat: add pre-commit hooks for black, isort, and codespell * ci: update python pipeline to use latest versions * refactor: apply code formatting fixes via pre-commit hooks * ci: split python ci/cd pipelines into multiple files * ci: add ci pipeline for checking style clang-format * refactor: remove unused config file for clang-format * refactor: remove duplicate file * ci: add ci pipeline that tests that codebase can build * refactor: update ci-build pipeline to only run on pull request * refactor: update clang-format config * refactor: apply clang-format * feat: update pipeline to build and run tests * refactor: disable linting checks when running colcon test * refactor: update .pre-commit-config file (#480) --------- Co-authored-by: Black Robot <[email protected]> Co-authored-by: Codespell Robot <[email protected]> Co-authored-by: Sondre Haugen <[email protected]>
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
…-auv into 434-task-dp-controller
for more information, see https://pre-commit.ci
...p_adapt_backs_controller/include/dp_adapt_backs_controller/dp_adapt_backs_controller_ros.hpp
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You really are HIM 🗣️ 🔥 Approving under the assumption that you've tested in sim / with physical orca
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍
🎉 This PR is included in version 2.2.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
DP controller with quaternion representation used.
The controller is tuned and works in the simulator
Added in docstring for the functions in .hpp file
ROS2 functions are defined separate from the normal functions ( cough Christopher asked for this cough )
Source: Trust me bro