diff --git a/sensors/bms/bms/freya_bms.py b/sensors/bms/bms/freya_bms.py index 921f041b..87740d05 100755 --- a/sensors/bms/bms/freya_bms.py +++ b/sensors/bms/bms/freya_bms.py @@ -1,8 +1,6 @@ import subprocess import rclpy.logging -#TODO: use ros2 logging instead of python print - class BMS: """ Class containing Freya's BMS system. diff --git a/sensors/bms/bms/freya_bms_node.py b/sensors/bms/bms/freya_bms_publisher_node.py similarity index 100% rename from sensors/bms/bms/freya_bms_node.py rename to sensors/bms/bms/freya_bms_publisher_node.py diff --git a/sensors/bms/launch/bms_launch.py b/sensors/bms/launch/bms_launch.py index f69d7658..a5067c28 100644 --- a/sensors/bms/launch/bms_launch.py +++ b/sensors/bms/launch/bms_launch.py @@ -5,6 +5,6 @@ def generate_launch_description(): return LaunchDescription([ Node( package='bms', - executable='bms_publisher' + executable='freya_bms_publisher_node' ) ]) \ No newline at end of file diff --git a/sensors/bms/package.xml b/sensors/bms/package.xml index cdc509d1..1871f6a3 100755 --- a/sensors/bms/package.xml +++ b/sensors/bms/package.xml @@ -2,10 +2,10 @@ bms - 0.0.0 - TODO: Package description - vortex - TODO: License declaration + 1.0.0 + Logs information about Freya's battery packs + vortex + TODO ament_copyright ament_flake8 diff --git a/sensors/bms/readme.md b/sensors/bms/readme.md index 6d173a47..28d2748b 100644 --- a/sensors/bms/readme.md +++ b/sensors/bms/readme.md @@ -4,7 +4,7 @@ This package contains a script for collecting BMS data, as well as a ROS node for publishing that -data. +data. The system is documented at [wiki page](https://vortex.a2hosted.com/index.php/Freya_BMS). ## ROS2 @@ -84,7 +84,10 @@ create_key_value_pair(key: str, value) -> KeyValue: ## Startup service -This package also contains a .service script for running the node on startup. To enable this, just run (from this directory) +Note: The .service file may need to be edited in order to source the setup.bash file +from the correct workspace. + +This package also contains a .service file for running the node on startup. To enable this, just run (from this directory) ``` sudo cp startup_script/bms_startup.service /etc/systemd/system/bms_startup.service ``` diff --git a/sensors/bms/setup.py b/sensors/bms/setup.py index aba227ee..a6c15722 100755 --- a/sensors/bms/setup.py +++ b/sensors/bms/setup.py @@ -23,7 +23,7 @@ tests_require=['pytest'], entry_points={ 'console_scripts': [ - 'bms_publisher = bms.freya_bms_node:main' + 'freya_bms_publisher_node = bms.freya_bms_publisher_node:main' ], }, )