remove SharedVec -> Arc<[Array]>

Author: a10y

encodings/datetime-parts/src/array.rs

@@ -61,7 +61,7 @@ impl DateTimePartsArray {
                 seconds_dtype: seconds.dtype().clone(),
                 subseconds_dtype: subsecond.dtype().clone(),
             },
-            vec![days, seconds, subsecond].into(),
+            [days, seconds, subsecond].into(),
             StatsSet::new(),
         )
     }

encodings/dict/src/dict.rs

@@ -36,7 +36,7 @@ impl DictArray {
                 codes_dtype: codes.dtype().clone(),
                 values_len: values.len(),
             },
-            vec![values, codes].into(),
+            [values, codes].into(),
             StatsSet::new(),
         )
     }

encodings/fastlanes/src/for/mod.rs

@@ -37,7 +37,7 @@ impl FoRArray {
             reference.dtype().clone(),
             child.len(),
             FoRMetadata { reference, shift },
-            vec![child].into(),
+            [child].into(),
             StatsSet::new(),
         )
     }

encodings/fsst/src/array.rs

@@ -1,3 +1,5 @@
+use std::sync::Arc;
+
 use fsst::{Decompressor, Symbol};
 use serde::{Deserialize, Serialize};
 use vortex::array::VarBinArray;
@@ -73,7 +75,7 @@ impl FSSTArray {
         let len = codes.len();
         let strings_dtype = codes.dtype().clone();
         let uncompressed_lengths_dtype = uncompressed_lengths.dtype().clone();
-        let children = vec![symbols, symbol_lengths, codes, uncompressed_lengths];
+        let children = Arc::new([symbols, symbol_lengths, codes, uncompressed_lengths]);
 
         Self::try_from_parts(
             dtype,
@@ -83,7 +85,7 @@ impl FSSTArray {
                 codes_dtype: strings_dtype,
                 uncompressed_lengths_dtype,
             },
-            children.into(),
+            children,
             StatsSet::new(),
         )
     }

encodings/zigzag/src/zigzag.rs

@@ -33,7 +33,7 @@ impl ZigZagArray {
             .with_nullability(encoded_dtype.nullability());
 
         let len = encoded.len();
-        let children = vec![encoded];
+        let children = [encoded];
 
         Self::try_from_parts(dtype, len, ZigZagMetadata, children.into(), StatsSet::new())
     }

vortex-array/src/arc_slice.rs

@@ -46,7 +46,7 @@ impl ConstantArray {
                 scalar: scalar.clone(),
                 length,
             },
-            vec![].into(),
+            [].into(),
             stats,
         )
         .unwrap_or_else(|err| {

vortex-array/src/array/constant/mod.rs

@@ -26,7 +26,7 @@ impl ExtensionArray {
             ExtensionMetadata {
                 storage_dtype: storage.dtype().clone(),
             },
-            vec![storage].into(),
+            [storage].into(),
             Default::default(),
         )
         .vortex_expect("Invalid ExtensionArray")

vortex-array/src/array/extension/mod.rs

@@ -24,7 +24,7 @@ impl NullArray {
             DType::Null,
             len,
             NullMetadata { len },
-            vec![].into(),
+            [].into(),
             StatsSet::nulls(len, &DType::Null),
         )
         .vortex_expect("NullArray::new should never fail!")

vortex-array/src/array/null/mod.rs

@@ -81,7 +81,7 @@ impl SparseArray {
                 len,
                 fill_value,
             },
-            vec![indices, values].into(),
+            [indices, values].into(),
             StatsSet::new(),
         )
     }

vortex-array/src/array/sparse/mod.rs

@@ -5,7 +5,6 @@ use vortex_dtype::DType;
 use vortex_error::{vortex_bail, vortex_panic, VortexResult};
 use vortex_scalar::Scalar;
 
-use crate::arc_slice::SharedVec;
 use crate::encoding::EncodingRef;
 use crate::stats::{Stat, Statistics, StatsSet};
 use crate::{Array, ArrayDType, ArrayMetadata, ToArray};
@@ -17,7 +16,7 @@ pub struct ArrayData {
     len: usize,
     metadata: Arc<dyn ArrayMetadata>,
     buffer: Option<Buffer>,
-    children: SharedVec<Array>,
+    children: Arc<[Array]>,
     stats_map: Arc<RwLock<StatsSet>>,
 }
 
@@ -28,7 +27,7 @@ impl ArrayData {
         len: usize,
         metadata: Arc<dyn ArrayMetadata>,
         buffer: Option<Buffer>,
-        children: SharedVec<Array>,
+        children: Arc<[Array]>,
         statistics: StatsSet,
     ) -> VortexResult<Self> {
         let data = Self {

vortex-array/src/data.rs

@@ -64,7 +64,7 @@ macro_rules! impl_encoding {
                     dtype: vortex_dtype::DType,
                     len: usize,
                     metadata: [<$Name Metadata>],
-                    children: $crate::arc_slice::SharedVec<$crate::Array>,
+                    children: std::sync::Arc<[$crate::Array]>,
                     stats: $crate::stats::StatsSet,
                 ) -> VortexResult<Self> {
                     Ok(Self { typed: $crate::TypedArray::try_from_parts(dtype, len, metadata, None, children, stats)? })

vortex-array/src/implementation.rs

@@ -35,7 +35,6 @@ use crate::variants::ArrayVariants;
 use crate::visitor::{AcceptArrayVisitor, ArrayVisitor};
 
 pub mod accessor;
-pub mod arc_slice;
 pub mod array;
 pub mod arrow;
 mod canonical;

vortex-array/src/lib.rs

@@ -4,7 +4,6 @@ use vortex_buffer::Buffer;
 use vortex_dtype::DType;
 use vortex_error::{vortex_bail, vortex_panic, VortexError, VortexResult};
 
-use crate::arc_slice::SharedVec;
 use crate::stats::StatsSet;
 use crate::{Array, ArrayData, ArrayDef, IntoArray, ToArray, TryDeserializeArrayMetadata};
 
@@ -20,7 +19,7 @@ impl<D: ArrayDef> TypedArray<D> {
         len: usize,
         metadata: D::Metadata,
         buffer: Option<Buffer>,
-        children: SharedVec<Array>,
+        children: Arc<[Array]>,
         stats: StatsSet,
     ) -> VortexResult<Self> {
         let array = Array::Data(ArrayData::try_new(

vortex-array/src/typed.rs

@@ -9,7 +9,6 @@ use vortex_dtype::{DType, Nullability};
 use vortex_error::{vortex_bail, vortex_err, VortexError, VortexExpect as _, VortexResult};
 use vortex_scalar::{PValue, Scalar, ScalarValue};
 
-use crate::arc_slice::SharedVec;
 use crate::encoding::EncodingRef;
 use crate::opaque::OpaqueEncoding;
 use crate::stats::{Stat, Statistics, StatsSet};
@@ -23,7 +22,7 @@ pub struct ArrayView {
     len: usize,
     flatbuffer: Buffer,
     flatbuffer_loc: usize,
-    buffers: SharedVec<Buffer>,
+    buffers: Arc<[Buffer]>,
     ctx: Arc<Context>,
     // TODO(ngates): a store a Projection. A projected ArrayView contains the full fb::Array
     //  metadata, but only the buffers from the selected columns. Therefore we need to know
@@ -74,7 +73,7 @@ impl ArrayView {
             len,
             flatbuffer,
             flatbuffer_loc,
-            buffers: SharedVec::from(buffers),
+            buffers: buffers.into(),
             ctx,
         };