Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

replace dev dependencies on react-navigation packages #45

Open
vonovak opened this issue Nov 11, 2021 · 0 comments
Open

replace dev dependencies on react-navigation packages #45

vonovak opened this issue Nov 11, 2021 · 0 comments

Comments

@vonovak
Copy link
Owner

vonovak commented Nov 11, 2021 •
edited
Loading

currently, the package has dev dependency on

    "@react-navigation/bottom-tabs": "^6.0.9",
    "@react-navigation/core": "^6.1.0",
    "@react-navigation/drawer": "^6.1.8",
    "@react-navigation/native-stack": "^6.2.4",
    "@react-navigation/stack": "^6.0.11",

so if installed in an app that only has eg. @react-navigation/stack, browsing its code will give TS errors. Type safety seems to be unaffected though
@vonovak vonovak changed the title replace dev dependenciesreact-navigation packages replace dev dependencies on react-navigation packages Nov 11, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@vonovak