Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

"Cannot read property 'replace' of undefined" when form has input doesn't have name attribute #16

Open
EdCordata opened this issue Apr 8, 2021 · 0 comments · May be fixed by #17
Open

"Cannot read property 'replace' of undefined" when form has input doesn't have name attribute #16

EdCordata opened this issue Apr 8, 2021 · 0 comments · May be fixed by #17

Comments

@EdCordata
Copy link

EdCordata commented Apr 8, 2021 •
edited
Loading

Many plugins append extra inputs to form, without name attributes.

For this reason, this plugin should check if the input has a name attribute, before trying to use it, so the user doesn't get this JavaScript error:

Uncaught TypeError: Cannot read property 'replace' of undefined
    at HTMLInputElement.showOrHideDependentFieldsRadio (dependent-fields.source.js.coffee:57)
    at executeBound (underscore.source.js:701)
    at HTMLInputElement.bound (underscore.source.js:733)
    at Function.each (jquery.source.js:370)
    at jQuery.fn.init.each (jquery.source.js:137)
    at Object.bind (dependent-fields.source.js.coffee:74)
    at Object.init.dependentFields (dependent-fields.source.js:2)
    at HTMLDocument.<anonymous> (application.source.js:35)
    at HTMLDocument.dispatch (jquery.source.js:5226)
    at HTMLDocument.elemData.handle (jquery.source.js:4878)

Error happens in this line:

$(".js-dependent-fields[data-radio-name=#{$radio.attr('name').replace(/\[/g, '\\[').replace(/]/g, '\\]')}]").each showOrHideFields

If im not mistaken, it can be fixed by just simply doing this:

$(".js-dependent-fields[data-radio-name=#{$radio.attr('name').toString().replace(/\[/g, '\\[').replace(/]/g, '\\]')}]").each showOrHideFields

or by updating selectors, when binding:

bind = ->
  $selects = $('select[name]')
@EdCordata EdCordata linked a pull request Apr 8, 2021 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix js error for fields without name attr EdCordata/dependent-fields-rails
1 participant
@EdCordata