Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conda packaging: env failure #390

Open
dominiquesydow opened this issue Jun 4, 2023 · 6 comments
Open

Conda packaging: env failure #390

dominiquesydow opened this issue Jun 4, 2023 · 6 comments
Assignees

Comments

@dominiquesydow
Copy link
Collaborator

Conda packaging for 2023.05.2 fails due to

The reported errors are:
- Encountered problems while solving:
   - nothing provides __cuda needed by pytorch-1.13.0-cuda112py310he33e0d6_200

---

conda_build.exceptions.DependencyNeedsBuildingError: Unsatisfiable dependencies for platform linux-64: {MatchSpec("pytorch==1.13.0=cuda112py310he33e0d6_200"), MatchSpec("__cuda")}

Full logs:
https://dev.azure.com/conda-forge/feedstock-builds/_build/results?buildId=717588&view=logs&jobId=656edd35-690f-5c53-9ba3-09c10d0bea97&j=656edd35-690f-5c53-9ba3-09c10d0bea97&t=e5c8ab1d-8ff9-5cae-b332-e15ae582ed2d

Ideas

  • Currently, we install pytorch from the pytorch channel. conda-forge states: "As a general rule: all dependencies have to be packaged by conda-forge as well. This is necessary to assure ABI compatibility for all our packages." --- can we install the package from conda-forge channel instead? https://anaconda.org/conda-forge/pytorch
@dominiquesydow
Copy link
Collaborator Author

dominiquesydow commented Jun 4, 2023

I am trying pytorch from the conda-forge channel for our teachopencadd conda package here:
https://dev.azure.com/conda-forge/feedstock-builds/_build/results?buildId=717595&view=logs&j=656edd35-690f-5c53-9ba3-09c10d0bea97

-> This seems to work for conda-forge, their CI is passing.

@dominiquesydow
Copy link
Collaborator Author

Pinging @AndreaVolkamer and @mbackenkoehler, could you please check with the DL team if the switch of channels still works fine for the DL talktorials?

@AndreaVolkamer
Copy link
Member

@PaulaKramer @joschka-gross @Old-Shatterhand can you comment on this?

@Old-Shatterhand
Copy link
Collaborator

That's an interesting error.

Intuitively, I would have said, it doesn't matter. To be on the safe side, adjust the CI/CD pipeline on GitHub and test it.

But then I checked the actual conda-packages on their respective channels: conda-forge and PyTorch. They are not just copies of each other (as it is the case for RDKit, afaik).
The conda-forge version has no support for win-64 and is one minor version behind the PyTorch channel. Also, the conda-forge builds are way smaller than the PyTorch builds. So, I'd say, the packages are not identical (as it might be the case for RDKit), but I doubt that they differ substantially and will brake the notebooks.

TL;DR: I'd update the CI/CD pipeline to conda-forge packages of PyTorch and rerun it. It will not work for Windows (as there is just no win-64 build of PyTorch on conda-forge), but I think on general Linux/MaxOS, this should not change the behavior of the notebooks.

@AndreaVolkamer
Copy link
Member

adressed in #394

@AndreaVolkamer
Copy link
Member

We will continue to work on this, but will merge the post-release fixes for now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants