Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add label key volcano.sh/task-index #98

Open
shuaiyy opened this issue Jan 18, 2023 · 0 comments
Open

add label key volcano.sh/task-index #98

shuaiyy opened this issue Jan 18, 2023 · 0 comments

Comments

@shuaiyy
Copy link

shuaiyy commented Jan 18, 2023

Is your feature request related to a problem? Please describe.
current, volcano task pod has label:

volcano.sh/job-name
volcano.sh/task-spec=worker

but missed task-index

task-index is important:

  • get task-index from pod object label, instead of parsing pod name
  • add a service by selector job-name task-spec task-index if someone need a k8s Service for a target task Pod
  • mount env from labels as a TASK_INDEX; the env plugin provide env key VC_TASK_INDEX which user cannot custom the name.

Describe the solution you'd like

add a volcano.sh/task-index to pod label

Describe alternatives you've considered

I want to know the reason why task-index not set to pod annotation

Additional context

the kubeflow training-operator project provider those labels in the task pod:

training.kubeflow.org/job-name
training.kubeflow.org/replica-type=chief
training.kubeflow.org/replica-index=0
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant