Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Kallsyms does a lot of stuff manually that should use the framework #1602

Open
ikelos opened this issue Feb 2, 2025 · 0 comments
Open

Kallsyms does a lot of stuff manually that should use the framework #1602

ikelos opened this issue Feb 2, 2025 · 0 comments

Comments

@ikelos
Copy link
Member

ikelos commented Feb 2, 2025

From #1599, there's [an open comment[(https://github.com//pull/1599/files/bf0271cd5765d656cc9a3844bb8b5c7e69e650ec#r1938483310) that points out that it does a lot of manual reads rather than using the framework. The rationale for this was to avoid loading symbol tables or similar, but since the plugin has a requirement on as kernel, the symbol table will have already been loaded (plus the needed symbols are just an array of pointers, which are both base types and therefore should be present regardless).

Rework get_task_callstack so that it creates an array of pointer -> void, which can then be used to get the address and value of the pointers.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant